Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Font Awesome 5 #466

Open
steven-pribilinskiy opened this issue Sep 7, 2018 · 0 comments
Open

Add support for Font Awesome 5 #466

steven-pribilinskiy opened this issue Sep 7, 2018 · 0 comments

Comments

@steven-pribilinskiy
Copy link

Please get rid of blocking icon_prefix option

In Font Awesome 5 icon sets are specified with fal fa- far fa- etc.

In the iconFunction there's that line that puts %2$s (e.g. far) placeholder twice thus making it uselesss with FontAwesome 5

sprintf('<%1$s class="%2$s %2$s-%3$s"></%1$s>', $this->iconTag, $iconSet, $icon);

Ideally there should be only icon_class that would work with any icon font

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant