Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solana connected status should be changed when permission is revoked #24974

Closed
srirambv opened this issue Aug 25, 2022 · 5 comments · Fixed by brave/brave-core#19123
Closed

Comments

@srirambv
Copy link
Contributor

Description

Blocked connection shows Green dot instead of red

Steps to Reproduce

  1. Connect to a Solana Dapp
  2. Check Panel shows 🟢 Connected
  3. Turn of Solana Dapp permission from brave://settings/content/solana
  4. Go back to Panel and check shows 🟢 Blocked instead of 🔴 Blocked

Actual result:

image

Expected result:

image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.43.81 Chromium: 104.0.5112.102 (Official Build) (arm64)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS macOS Version 12.5.1 (Build 21G83)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @darkdh @Douglashdaniel

@darkdh
Copy link
Member

darkdh commented Aug 25, 2022

The green status came from "connected" status because it is still connected after we set Solana permission to blocked.
We should consider doing automatically disconnect when Solana permission changed to blocked per site or globally.

@darkdh
Copy link
Member

darkdh commented Jun 16, 2023

Resurface this issue with latest UI since @mrose17 brought this up when integrating wallet with Brave Talk.
Screen Shot 2023-06-16 at 15 20 24
Screen Shot 2023-06-16 at 15 20 38

Beside clearing the connected status when permission is removed we should also emit "disconnect" event to let dapps know this happens.

@darkdh darkdh changed the title Blocked connection shows Green dot instead of red Solana connected status should changed when permission is revoked Jun 16, 2023
@mrose17
Copy link
Member

mrose17 commented Jun 16, 2023

@mrose17 - would like to be in the loop on this!

@Douglashdaniel
Copy link

Tested with Phantom and it looks like they do emit a disconnect event when revoking.

Screen.Recording.3.mov

@darkdh darkdh self-assigned this Jun 29, 2023
@brave-builds brave-builds added this to the 1.55.x - Nightly milestone Jul 6, 2023
@rebron rebron changed the title Solana connected status should changed when permission is revoked Solana connected status should be changed when permission is revoked Aug 31, 2023
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.58.108 Chromium: 116.0.5845.114 (Official Build) beta (64-bit)
Revision f08ffbe3ce0069ad8207b9d2d7dee38afcccc1b9
OS Windows 11 Version 22H2 (Build 22621.2215)
  • Verified steps from issue description and brave/brave-core#19123
  • Verified connection status is properly shown on panel when connected to Dapps
24974.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants