Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-fill Coingecko IDs while adding custom tokens #31975

Closed
onyb opened this issue Jul 31, 2023 · 1 comment · Fixed by brave/brave-core#19489
Closed

Auto-fill Coingecko IDs while adding custom tokens #31975

onyb opened this issue Jul 31, 2023 · 1 comment · Fixed by brave/brave-core#19489
Assignees
@onyb
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.58.x - Release

Comments

@onyb
Copy link
Member

onyb commented Jul 31, 2023

Thanks to brave/token-lists#71, we now have access to all possible Coingecko IDs mapped for each chain ID and contract address pair.

Definition of done

  • The Coingecko ID field gets pre-filled when adding a custom token under Visible Assets
  • The Coingecko ID is inferred automatically when adding a custom token through wallet_watchAsset method.
Screenshot 2023-07-31 at 11 33 43
@onyb onyb self-assigned this Jul 31, 2023
@onyb onyb mentioned this issue Jul 31, 2023
Merged
25 tasks
@StephenHeaps StephenHeaps mentioned this issue Mar 8, 2024
Open
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Aug 4, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.58.100 Chromium: 116.0.5845.114 (Official Build) beta (64-bit)
Revision a8c0058265009a1858c4502b9ba413671fbb61e1
OS Windows 11 Version 22H2 (Build 22621.2215)
  • Verified steps from brave/brave-core#19489
  • Verified CoinGecko ID is auto populated when adding custom tokens
31975.mp4

@LaurenWags LaurenWags mentioned this issue Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): inject coingecko id for custom tokens brave/brave-core
3 participants
@onyb @srirambv @brave-builds