Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

News general usage metrics not triggering properly #35676

Closed
Tracked by #35960
DJAndries opened this issue Jan 29, 2024 · 2 comments · Fixed by brave/brave-core#21805
Closed
Tracked by #35960

News general usage metrics not triggering properly #35676

DJAndries opened this issue Jan 29, 2024 · 2 comments · Fixed by brave/brave-core#21805
Assignees
@DJAndries
Labels
feature/brave-news formerly brave-today features/P3A OS/Desktop QA/No release-notes/exclude
Milestone
1.62.x - Release #3

Comments

@DJAndries
Copy link
Collaborator

The News general usage metrics (Brave.Today.UsageMonthly and Brave.Today.UsageDaily) will intermittently not trigger when the user scrolls down to view the feed. The metrics are also not triggered when the user clicks on the peeking card.

cc @LorenzoMinto
@DJAndries DJAndries self-assigned this Jan 29, 2024
@DJAndries DJAndries mentioned this issue Jan 29, 2024
Merged
24 tasks
@LorenzoMinto
Copy link
Member

Fix looks great. Do you think we could uplift this? For context, we are seeing a considerable drop in the P3A DAU metric cc @fallaciousreasoning @rebron

@DJAndries
Copy link
Collaborator Author

Do you think we could uplift this?

absolutely, will uplift once merged

@brave-builds brave-builds added this to the 1.64.x - Nightly milestone Jan 30, 2024
This was referenced Jan 30, 2024
Merged
Merged
@LorenzoMinto LorenzoMinto mentioned this issue Feb 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DJAndries DJAndries

Labels
feature/brave-news formerly brave-today features/P3A OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.62.x - Release #3
Development

Successfully merging a pull request may close this issue.

Fix News general usage metrics brave/brave-core
4 participants
@kjozwiak @DJAndries @LorenzoMinto @brave-builds