Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split View – "Switch to This Tab" doesn't actually switch to that tab #41187

Open
4 of 6 tasks
marlonjames71 opened this issue Sep 21, 2024 · 0 comments
Open
4 of 6 tasks

Comments

@marlonjames71
Copy link

marlonjames71 commented Sep 21, 2024

Description

When creating a new Split View, you can start typing the title of an already open tab and you get the option "Switch to This Tab" which is great. Only thing is when acted on, it doesn't actually take that tab and move it into the split view. It duplicates the tab instead which is not very useful and gives the user more unnecessary things to manage.

The only time I think a tab should be duplicated in this scenario is if I'm trying to open a tab that is in a tab group. The user may want to keep that tab in the tab group for future reference.

All of this being said, I think the verbiage could be a little more clear. If Brave implemented what I'm suggesting here I think it could be better worded as such:

  • Tab from a tab group: "Open In Split View"
  • Open tab not in a tab group: "Move to Split View"

Steps to reproduce

  1. Enable #brave-split-view flag
  2. Create new split view
  3. In the address bar, start typing the name/title of an already open tab
  4. Select the option that says "Switch to This Tab"

Actual result

Tab gets duplicated instead of being moved to the split view.

Expected result

Tab ends up moving into the split view no longer remaining where it was, and not being duplicated.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.71.90 Chromium: 129.0.6668.59 (Official Build) beta (arm64)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant