Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claim banners are of different text size #4171

Closed
srirambv opened this issue Apr 19, 2019 · 6 comments · Fixed by brave/brave-core#2173
Closed

Claim banners are of different text size #4171

srirambv opened this issue Apr 19, 2019 · 6 comments · Fixed by brave/brave-core#2173

Comments

@srirambv
Copy link
Contributor

Description

Claim banners are of differnt text size

Actual result:

Screenshot from 2019-04-18 20-02-01

Expected result:

Text should be of same size

Reproduces how often:

Easy

Brave version (brave://version info)

@jsecretan
Copy link

Might get resolved by this: brave/brave-core#2173

@LaurenWags
Copy link
Member

Reproduced on macOS

Brave 0.63.47 Chromium: 74.0.3729.108 (Official Build) (64-bit)
Revision daaff52abef89988bf2a26091062160b1482b108-refs/branch-heads/3729@{#901}
OS Mac OS X

@rossmoody
Copy link
Contributor

@LaurenWags are you still seeing this on Mac on nightly build?

@rossmoody
Copy link
Contributor

Also technically this issue was the alert component not spanning the width of the column, the text sizes are the same size.

@LaurenWags
Copy link
Member

@rossmoody looks good with 0.66.21 on Nightly

Brave 0.66.21 Chromium: 74.0.3729.108 (Official Build)nightly (64-bit)
Revision daaff52abef89988bf2a26091062160b1482b108-refs/branch-heads/3729@{#901}
OS Mac OS X

Screen Shot 2019-04-24 at 2 50 25 PM

@kjozwiak
Copy link
Member

kjozwiak commented Jun 11, 2019

Verification PASSED on macOS 10.14.5 x64 using the following build:

Brave 0.66.87 Chromium: 75.0.3770.80 (Official Build) beta(64-bit)
Revision 9a9aa15057b6b2cc0909bdcf638c0b65ecd516f2-refs/branch-heads/3770@{#948}
OS Mac OS X

Screen Shot 2019-06-11 at 1 05 49 PM

Also ensured that claiming both grants works without any issues:

Screen Shot 2019-06-11 at 1 06 20 PM

Verification passed on

Brave 0.66.87 Chromium: 75.0.3770.80 (Official Build) beta (64-bit)
Revision 9a9aa15057b6b2cc0909bdcf638c0b65ecd516f2-refs/branch-heads/3770@{#948}
OS Windows 7 Service Pack 1 (Build 7601.24465)

image

Verification passed on

Brave 0.66.87 Chromium: 75.0.3770.80 (Official Build) beta (64-bit)
Revision 9a9aa15057b6b2cc0909bdcf638c0b65ecd516f2-refs/branch-heads/3770@{#948}
OS Linux

image

@rebron rebron changed the title Claim banners are of differnt text size Claim banners are of different text size Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment