New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bounds checking in draw_horizontal_line #7

Open

sharpie7 opened this issue May 28, 2022 · 0 comments

sharpie7 commented May 28, 2022

draw_horizontal_line doesn't check its bounds correctly and can stamp over memory outside the bitmap.

The vertical position isn't checked before attempting to draw the line.

The horizontal position is clipped to max of width and should be clipped to width-1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment