Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to Data Files? #46

Open
lbussy opened this issue Jul 9, 2019 · 0 comments
Open

Link to Data Files? #46

lbussy opened this issue Jul 9, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@lbussy
Copy link
Member

lbussy commented Jul 9, 2019

In an effort to reduce the amount of churn/scripting, explore the potential to create a symlink from brewpi/data to www/data and keep everything in the web directories owned by brewpi:www-data.

The logic to write to brewpi/data and then copy to www/data has been part of brewpi.py since v0.1 and there's a warning in the source code indicating that it's done to prevent locking the file:

# Do not write directly to www dir to prevent blocking www file.

I've posted a question for Elco to see if he remembers why that was done since it's hard to imagine locking the file to the point where reading it while it's being written would break things.

Only going to do his or #47 ... not both.

@lbussy lbussy mentioned this issue Jul 9, 2019
@lbussy lbussy self-assigned this Jul 9, 2019
@lbussy lbussy added enhancement New feature or request question Further information is requested labels Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant