Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that the Rust, C, and asm code all agree on alignments and other ABI issues for all types #629

Closed
briansmith opened this issue Jan 26, 2018 · 2 comments

Comments

@briansmith
Copy link
Owner

See #628 for background.

It's possible we might use a C compiler that has a different idea about alignment than the Rust compiler has. In particular, when the Rust compiler calls into C code, it might do so with objects that aren't aligned as much as the C code expects. Similarly with the asm code.

We already have some checks for primitive types using DEFINE_METRICS in C code and define_metrics_tests in Rust code. We could expand this to include all the non-primitive types shared between Rust and C too.

We should also see if we can somehow check "once and for all" that the ABIs match.

We might need to split checks/assurances for non-alignment ABI issues into a separate issue.

@briansmith
Copy link
Owner Author

Besides #628, see rust-lang/rust#45094 for more background.

@briansmith
Copy link
Owner Author

Closing as I believe this has been done for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant