Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tone mapping to not get blown out colours #161

Open
davepagurek opened this issue Oct 8, 2018 · 0 comments
Open

Use tone mapping to not get blown out colours #161

davepagurek opened this issue Oct 8, 2018 · 0 comments
Labels
enhancement New feature or request low-priority rendererer

Comments

@davepagurek
Copy link
Member

Right now when things get too close to lights, we get large white spots where the additive light goes over the maximum value.

A simple fix is to drop in John Hable's tone mapping function:
https://github.com/davepagurek/everything/blob/master/src/commands/composite.js#L60-L68

We can add this into our createDrawObjects shader before setting gl_FragColor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request low-priority rendererer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davepagurek