Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow time to be selected on mobile for WMS time layers #67

Open
3 tasks
maltaesousa opened this issue May 11, 2022 · 10 comments
Open
3 tasks

Allow time to be selected on mobile for WMS time layers #67

maltaesousa opened this issue May 11, 2022 · 10 comments
Labels

Comments

@maltaesousa
Copy link
Collaborator

maltaesousa commented May 11, 2022

Who requested this new feature?

SITN

Is your feature request related to a problem?

No

Describe the solution you'd like

On desktop, times can be selected for wms time layers but not on mobiles. It would be nice to have both implementations: time picker and time slider for single or range times.

EDIT:

A workaround has been found but it's not optimal:

  • Press on the time selector should be easy for fingers
  • Once time is selected, we should be able to close the popover easily (maybe a modal would fit better for mobile) without clicking on map or layertree
  • translations are made
@pfanguin
Copy link

@maltaesousa I was just making an issue for this !
There are several improvements to be made for mobile, maybe we can make a single issue ?

@maltaesousa
Copy link
Collaborator Author

maltaesousa commented May 11, 2022

I don't know @pfanguin Big issues might be harder to fund and when we will ask for money it will be more readable to have small issues. What we can do is create a mobile label so we can easily filter them?

@remyguillaume
Copy link
Collaborator

@maltaesousa @pfanguin Do you mean something like this ? https://map.geo.bs.ch/s/K0G0
It's working at BS, bit I don't think de have made any big change for this.
If this is what you are looking for, I can look and share how we have configured it.

@pfanguin
Copy link

@maltaesousa ok perfect I understand. Thanks for you response !
@remyguillaume yes exactly !

@remyguillaume
Copy link
Collaborator

@pfanguin @maltaesousa

I just looked at how we solved this in BS, and actually we've just overridden some CSS :

.gmf-layertree-node [ngeo-popover][ngeo-popover-dismiss] {
    display: flex;
}

But we are still in 2.4 for now. Perhaps this will be a little different in your version.

@maltaesousa
Copy link
Collaborator Author

Thanks @remyguillaume it works great! For our intance we needed to override CSS like this because the popover tilte was not being translated :

.gmf-layertree-node [ngeo-popover][ngeo-popover-dismiss] {
  display: inline;
}

.popover-header {
  display: none;
}

@pfanguin tell me if this work around is ok for you. If it is, I will close this issue.

@rbovard
Copy link
Collaborator

rbovard commented May 13, 2022

@maltaesousa Is it possible to push it directly in GMF or it's too "hacky"?

@maltaesousa
Copy link
Collaborator Author

It's too hacky:

  • Pressing on the clock icon is not easy: the icon is too small for fingers
  • Hiding popover-header because it's not translated is not a good solution
  • Once you've selected the date, you have to press outside popover to close it. On mobile in portrait, you end up by clicking in layertree and activating another layer :/

@pfanguin
Copy link

@maltaesousa Yes it's work but we need some css to do this work around. It's could not be better to ask for a true integration ?

@maltaesousa
Copy link
Collaborator Author

Ok, so let's keep this open!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants