Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox opening under modal #1530

Closed
huineng opened this issue Sep 17, 2020 · 8 comments
Closed

Combobox opening under modal #1530

huineng opened this issue Sep 17, 2020 · 8 comments
Assignees
Labels
component: Combobox For Combobox issues

Comments

@huineng
Copy link

huineng commented Sep 17, 2020

It's getting quite messy , spent whole day and still not working

I have tried to implement the combobox with 2 alternatives ..

  1. using the itemValueKey.. but here i hit the problem as you also have on your demo webpage
    https://angular.carbondesignsystem.com/?path=/story/components-combobox--with-reactive-forms

image

now clear that item or select any other value
in case you clear that item, whatever you select is not shown on screen

image

or if you don't clear, the value always stays the same
image

see the "selected"

Please help me out urgently , i'm promoting this library but with every update , i think new problems are created

  1. without itemValueKey

i'm not even sure where to start, maybe related with your upgrade to angular 10 (which i was using when you were not yet on ng10 ) and your previous version WAS working , so it might be your upgrade to angular 10

So i had to change to using "temValueKey" that at least didn't give me any error ( just the bug above)

this is the bug i got

  "TypeError: Cannot assign to read only property 'selected' of object '[object Object]'",
     "    at DropdownList.push.8a99f462d6cebb67ffa6.DropdownList.doClick )",
     "    at Object.eval [as handleEvent] (ng:///DropdownModule/DropdownList.ngfactory.js:66:23)",
     "    at handleEvent ",
     "    at callWithDebugContext"

thanks

@huineng
Copy link
Author

huineng commented Sep 18, 2020

@huineng
Copy link
Author

huineng commented Sep 18, 2020

@cal-smith cal-smith added the Hacktoberfest The smell of pumpkin and hacking is in the air! label Sep 24, 2020
@tacho090
Copy link

@huineng was the issue solved by #1539?

@huineng
Copy link
Author

huineng commented Oct 16, 2020

@cal-smith cal-smith added component: Combobox For Combobox issues and removed Hacktoberfest The smell of pumpkin and hacking is in the air! labels Nov 4, 2020
@cal-smith
Copy link
Contributor

I'm not sure what's going on with the z-index there 😱 As a work around you should be able to target .bx--list-box--expanded and give it a high enough z-index ... We may want to consider explicitly adding it to the styles to sort out these edge cases 🤔

@cal-smith cal-smith changed the title Combobox not working with reactive forms Combobox opening under modal Jan 18, 2021
@huineng
Copy link
Author

huineng commented Jan 19, 2021

For me you can close it, i don't have that problem with my apps, i just thought it might be an issue in the library

@cal-smith
Copy link
Contributor

Gotcha 👍 I'll leave it for the moment, since it seems like something that can be fixed generally

@zvonimirfras zvonimirfras self-assigned this Mar 16, 2021
@zvonimirfras
Copy link
Member

Should be fixed with carbon-design-system/carbon#8107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Combobox For Combobox issues
Projects
None yet
Development

No branches or pull requests

4 participants