Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notification] Inline notification inconsistency and visual inaccuracy #868

Open
5 tasks
Kritvi-bhatia17 opened this issue Sep 18, 2024 · 0 comments
Open
5 tasks

Comments

@Kritvi-bhatia17
Copy link

Detailed description

  1. Inconsistency in Figma:

    The "Inline long" and "Inline short" types are neither documented in Storybook nor on our website, although they are present in Figma. These types were intended to indicate whether the notification text should be on one line or wrap to multiple lines. To address this, we are considering removing the "Inline short" and "Inline long" distinctions from the Figma kit and consolidating them into a single "Inline" label.

    image
  2. Visual Inaccuracy of Inline long notification

    The "Inline long" type is visually incorrect. The Title and Message should start on the same line, similar to the "Inline short" type, and then wrap if the text is too long. (Related issue)

    image

Steps to reproduce the issue

  • Remove the "Inline short" and "Inline long" distinctions from the Figma kit and consolidating them into a single "Inline" label.
  • Explore the ways to address the visual inconsistency of "Inline long" in Figma so that it aligns with the "Inline short" format.
  • Review
    • Carbon designer
    • Figma expert

Additional information

⭐️ Important Note

After fixing the inconsistencies in Figma, we will need to create issues to address: 

- The visual accuracy of "Inline long" in Storybook.
- Update the website documentation to reflect the same.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ⏱ Backlog
Status: Triage
Development

No branches or pull requests

1 participant