Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Shell Left panel guidance missing content, and other considerations #3235

Closed
mbgower opened this issue Nov 1, 2022 · 1 comment
Closed

Comments

@mbgower
Copy link
Contributor

mbgower commented Nov 1, 2022

This is a summary of considerations identified from reviews of the Usage and Style content. It provides information different from that described as bugs for the component listed in carbon-design-system/carbon#12323

  • usage topic is missing Live demo, Interaction and References section
  • the UI Shell topics are treated as a strange hybrid in the Usage introduction, yet are separate components in the Carbon guidance
  • Style page seems to use the same image twice by accident

More details and minor considerations are captured as comments in the Usage and Style PDF exports.

In addition, a reviews of Figma's left panel shows that diagrams incorrectly use "link" where they are clearly demonstrating an expandable section. As per comments in UI Shell Header, Carbon needs to adopt the best descriptor for this component/behaviour and use it consistently throughout the header/left/right UI Shell material.
image

@mbgower mbgower changed the title UI Shell Left panel missing content, and other considerations UI Shell Left panel guidacne missing content, and other considerations Nov 1, 2022
@mbgower mbgower changed the title UI Shell Left panel guidacne missing content, and other considerations UI Shell Left panel guidance missing content, and other considerations Nov 1, 2022
@laurenmrice
Copy link
Member

Closing this to separate the work for this out into two different issues. This issue will be cross-linked and referenced in the issues below:

@laurenmrice laurenmrice closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants