From 3f54ea9abe5571532afc2b3b0d3b0aa2a01ac5ec Mon Sep 17 00:00:00 2001 From: TJ Egan Date: Mon, 14 Nov 2022 17:32:07 -0500 Subject: [PATCH] fix(CopyButton): remove extraneous title attribute (#12394) * fix(CopyButton): remove extraneous title attribute * test(CodeSNippet): update CodeSnippet tests to not use title attribute Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> --- .../src/components/CodeSnippet/__tests__/CodeSnippet-test.js | 4 ++-- packages/react/src/components/CopyButton/CopyButton.js | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/react/src/components/CodeSnippet/__tests__/CodeSnippet-test.js b/packages/react/src/components/CodeSnippet/__tests__/CodeSnippet-test.js index 444cc2348efa..bf95c829e213 100644 --- a/packages/react/src/components/CodeSnippet/__tests__/CodeSnippet-test.js +++ b/packages/react/src/components/CodeSnippet/__tests__/CodeSnippet-test.js @@ -136,7 +136,7 @@ describe('CodeSnippet', () => { ); - expect(screen.getByTitle('Copy to clipboard')).toHaveAttribute('disabled'); + expect(document.querySelector('button')).toHaveAttribute('disabled'); }); }); @@ -149,7 +149,7 @@ describe('CodeSnippet events', () => { ); - const button = screen.getByTitle('Copy to clipboard'); + const button = document.querySelector('button'); userEvent.click(button); expect(onClick).toHaveBeenCalled(); }); diff --git a/packages/react/src/components/CopyButton/CopyButton.js b/packages/react/src/components/CopyButton/CopyButton.js index a1d54405bb7b..b203b99674d4 100644 --- a/packages/react/src/components/CopyButton/CopyButton.js +++ b/packages/react/src/components/CopyButton/CopyButton.js @@ -18,7 +18,6 @@ export default function CopyButton({ iconDescription, className, ...other }) {