fix(Button): remove default tabIndex (#13171)

Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
carbon-design-system · Feb 23, 2023 · 56bdbe0 · 56bdbe0
1 parent 36685a0
commit 56bdbe0
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 12 deletions.
diff --git a/packages/react/src/components/Button/Button.js b/packages/react/src/components/Button/Button.js
@@ -34,7 +34,7 @@ const Button = React.forwardRef(function Button(
     onMouseLeave,
     renderIcon: ButtonImageElement,
     size = 'lg',
-    tabIndex = 0,
+    tabIndex,
     tooltipAlignment = 'center',
     tooltipPosition = 'top',
     type = 'button',

diff --git a/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap b/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap
@@ -2045,7 +2045,6 @@ exports[`DataTable should render 1`] = `
                         className="cds--btn cds--btn--primary"
                         disabled={false}
                         onClick={[MockFunction]}
-                        tabIndex={0}
                         type="button"
                       >
                         Ghost
@@ -2124,7 +2123,6 @@ exports[`DataTable should render 1`] = `
                         className="cds--btn cds--btn--primary"
                         disabled={false}
                         onClick={[MockFunction]}
-                        tabIndex={0}
                         type="button"
                       >
                         Ghost
@@ -2203,7 +2201,6 @@ exports[`DataTable should render 1`] = `
                         className="cds--btn cds--btn--primary"
                         disabled={false}
                         onClick={[MockFunction]}
-                        tabIndex={0}
                         type="button"
                       >
                         Ghost
@@ -2517,7 +2514,6 @@ exports[`DataTable should render 1`] = `
                                     onKeyDown={[Function]}
                                     onMouseEnter={[Function]}
                                     open={false}
-                                    tabIndex={0}
                                     title="Settings"
                                     type="button"
                                   >
@@ -2600,7 +2596,6 @@ exports[`DataTable should render 1`] = `
                   className="cds--btn cds--btn--sm cds--btn--primary"
                   disabled={false}
                   onClick={[MockFunction]}
-                  tabIndex={0}
                   type="button"
                 >
                   Add new
@@ -3172,7 +3167,6 @@ exports[`DataTable sticky header should render 1`] = `
                         className="cds--btn cds--btn--primary"
                         disabled={false}
                         onClick={[MockFunction]}
-                        tabIndex={0}
                         type="button"
                       >
                         Ghost
@@ -3251,7 +3245,6 @@ exports[`DataTable sticky header should render 1`] = `
                         className="cds--btn cds--btn--primary"
                         disabled={false}
                         onClick={[MockFunction]}
-                        tabIndex={0}
                         type="button"
                       >
                         Ghost
@@ -3330,7 +3323,6 @@ exports[`DataTable sticky header should render 1`] = `
                         className="cds--btn cds--btn--primary"
                         disabled={false}
                         onClick={[MockFunction]}
-                        tabIndex={0}
                         type="button"
                       >
                         Ghost
@@ -3644,7 +3636,6 @@ exports[`DataTable sticky header should render 1`] = `
                                     onKeyDown={[Function]}
                                     onMouseEnter={[Function]}
                                     open={false}
-                                    tabIndex={0}
                                     title="Settings"
                                     type="button"
                                   >
@@ -3727,7 +3718,6 @@ exports[`DataTable sticky header should render 1`] = `
                   className="cds--btn cds--btn--sm cds--btn--primary"
                   disabled={false}
                   onClick={[MockFunction]}
-                  tabIndex={0}
                   type="button"
                 >
                   Add new

diff --git a/...ages/react/src/components/DataTable/__tests__/__snapshots__/TableToolbarMenu-test.js.snap b/...ages/react/src/components/DataTable/__tests__/__snapshots__/TableToolbarMenu-test.js.snap
@@ -125,7 +125,6 @@ exports[`DataTable.TableToolbarMenu should render 1`] = `
                       onKeyDown={[Function]}
                       onMouseEnter={[Function]}
                       open={false}
-                      tabIndex={0}
                       title="Add"
                       type="button"
                     >