Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[popover]: caret should be 16px away from edge of popover #10286

Closed
2 tasks done
Tracked by #10316
laurenmrice opened this issue Dec 14, 2021 · 0 comments · Fixed by #10539
Closed
2 tasks done
Tracked by #10316

[popover]: caret should be 16px away from edge of popover #10286

laurenmrice opened this issue Dec 14, 2021 · 0 comments · Fixed by #10539
Assignees
@dakahn
Labels
component: popover role: dev 🤖 type: bug 🐛
Milestone
v11 Release Candi...

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Dec 14, 2021 •
edited
Loading

Package

carbon-components

Browser

Chrome, Safari, Firefox

Package version

v10.49.0

Description

When the popover component has a caret tip, the caret tip should always be placed 16px away from the edge of the container. The caret should be aligned to the type that is also following the 16px padding and the caret tip should still be vertically center with the trigger button.

Screenshots

Example alignment:
Artboard 1

Steps to reproduce

View the experimental popover story in react:
https://deploy-preview-9965--carbon-react-next.netlify.app/?path=/story/experimental-unstable-popover--playground

Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dakahn dakahn

Labels
component: popover role: dev 🤖 type: bug 🐛
Projects
Design System
Archived in project
Milestone
v11 Release Candidate 1
Development

Successfully merging a pull request may close this issue.

fix(Popover): adjust popover content placement dakahn/carbon
4 participants
@tay1orjones @joshblack @dakahn @laurenmrice