Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for hosted option through Google Fonts #10353

Closed
Tracked by #10316 ...
joshblack opened this issue Jan 6, 2022 · 0 comments · Fixed by #10393
Closed
Tracked by #10316 ...

Add support for hosted option through Google Fonts #10353

joshblack opened this issue Jan 6, 2022 · 0 comments · Fixed by #10393
Assignees

Comments

@joshblack
Copy link
Contributor

joshblack commented Jan 6, 2022

As part of our IBM Plex for v11, we added support for using fonts directly from the @ibm/plex package. However, we would like to keep our hosted option available that is available in v10. This will help teams migrate from v10 to v11 and also provides an alternate setup out-of-the-box when using Carbon.

The default behavior in v11 will be to use fonts directly from @ibm/plex, to enable hosting we should support a flag in the config package that enables hosted fonts and disables custom @font-face blocks from the package.

The difference between hosted and non-hosted is simply the value of the url() in the @font-face block. Most likely we could use our resolver to implement the logic for getting the correct url path when hosted is set to true in config.

@joshblack joshblack changed the title Add support for hosted option through Google Fonts @tw15egan Add support for hosted option through Google Fonts Jan 6, 2022
@joshblack joshblack added this to the v11 Release Candidate 0 milestone Jan 6, 2022
@joshblack joshblack mentioned this issue Jan 6, 2022
25 tasks
@kodiakhq kodiakhq bot closed this as completed in #10393 Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants