Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeSnippet: Remove or improve the overflow indicators #8059

Closed
guigueb opened this issue Mar 10, 2021 · 1 comment
Closed

CodeSnippet: Remove or improve the overflow indicators #8059

guigueb opened this issue Mar 10, 2021 · 1 comment
Labels
adopter: product Work-stream that directly helps a Product team. component: code-snippet package: @carbon/react @carbon/react proposal: open This request has gone through triaging. We're determining whether we take this on or not. role: design ✏️ type: enhancement 💡 version: 11 Issues pertaining to Carbon v11

Comments

@guigueb
Copy link
Contributor

guigueb commented Mar 10, 2021

Summary

The CodeSnippet component has grey shading zones on the left and right zones of scrollable content.
There needs to be a better way to indicate scrollable (see #8057 and #7574).
And it needs to be applicable for both horizontal and vertical scrollable content.

Justification

The shading zones are of little (and sometimes no) use.
They are very subtle and easily overlooked.
If there is no content in the shading zones they have no effect at all (there is nothing to shade).
On all platforms besides apple scrollbars are always visible (indicating scrollable content) and the shading zones are not needed.

Apple users are aware/used to hidden scrollbars and have the option of turning them on (https://www.matuzo.at/blog/css-pro-tip-for-mac-users-always-show-scroll-bars-in-macos/)

The overflow indicators should be removed, and replaced with a more stable/noticeable option.
One solution would be to always force CodeSnippet to show scrollbars.
This would make it consistent across platforms (apple and others) and clearly show what scrolling is available.

Desired UX and success metrics

Testcase:
Given a CodeSnippet with data that overflows its container; it would be nice to be able to identify that scrolling to view more data is possible.

"Must have" functionality

No matter what the data is there needs to be some way to know that scrolling is an option.

Specific timeline issues / requests

nope

Available extra resources

What resources do you have to assist this effort?

Maybe

@sstrubberg
Copy link
Member

Hey @guigueb, thanks for opening the request. Here are some notes from our backlog cleaning meeting today.

  • If a consumer enables show scroll bars within their OS preferences, this is mostly taken care of.image

  • The shading zones you are referring to are more of a secondary indicator of scrollable content.

  • Adjacently, @alisonjoseph made a fix to address the overflow which improves the usability of the scrollbars, which supplant the “secondary indicator” fade.

  • Lastly, if you or a designer had a more concrete spec on how we could improve the overflow indicators, we would love to consider it.

@sstrubberg sstrubberg closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adopter: product Work-stream that directly helps a Product team. component: code-snippet package: @carbon/react @carbon/react proposal: open This request has gone through triaging. We're determining whether we take this on or not. role: design ✏️ type: enhancement 💡 version: 11 Issues pertaining to Carbon v11
Projects
Archived in project
Development

No branches or pull requests

3 participants