Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[search] extend search field in mobile to allow users to enter a term #1049

Closed
jeanservaas opened this issue Oct 30, 2020 · 7 comments · Fixed by #1050
Closed

[search] extend search field in mobile to allow users to enter a term #1049

jeanservaas opened this issue Oct 30, 2020 · 7 comments · Fixed by #1050
Assignees

Comments

@jeanservaas
Copy link
Contributor

  1. Right now in mobile, it's not possible for users to trigger the typewriter to enter a search term on their phones because the field does not extend wide enough.

  2. Mike wanted to try to get the search width onto the grid at the desktop and tablet breakpoints as well.

1. Expand Mobile search

Current

IMG_2256

Please span the search to the left side of the hamburger menu (see below) to make it as easy as possible for users to interact with it.

Expected

image

2. Modify search width to align with grid at all breakpoints.

Align edge of open Search field with the edge of the first tab on the banner at all breakpoints.

Expected

1312 breakpoint example (do same alignment through tablet)
image

@alisonjoseph
Copy link
Member

moving this to the theme repo, since this needs to be handled at the theme level vs. just for the Carbon website

@alisonjoseph alisonjoseph transferred this issue from carbon-design-system/carbon-website Nov 2, 2020
@alisonjoseph alisonjoseph self-assigned this Nov 2, 2020
@jnm2377
Copy link
Contributor

jnm2377 commented Jan 15, 2021

@jeanservaas should we re-open this if the search isn't aligning to page tabs or is the full width intentional?
Screen Shot 2021-01-15 at 1 51 18 PM
Screen Shot 2021-01-15 at 2 00 00 PM

@jeanservaas jeanservaas reopened this Jan 15, 2021
@jeanservaas
Copy link
Contributor Author

Great call @jnm2377 ! Thanks for catching this. I just reopened the issue and I wonder if I missed this while reviewing it or something.

The expected behavior in desktop is this:

image

Not this:

image

@mjabbink
Copy link
Contributor

mjabbink commented Feb 1, 2021

Can we get this done please.

@mjabbink
Copy link
Contributor

mjabbink commented Feb 4, 2021

@jeanservaas I was checking on the preview link for the Workplace site and played with the extended search and the issue we need to take into account is the results that span across the entire width. I think we need to spec right side margin to prevent this.

Screen Shot 2021-02-03 at 8 41 05 PM

@mjabbink
Copy link
Contributor

@jeanservaas Did you connect with @alisonjoseph on this for specs on width of search result text?

@vpicone
Copy link
Collaborator

vpicone commented Feb 25, 2021

Following up with what @mjabbink mentioned, @jeanservaas the shell sits on top of the grid. Is it tied to that specific anchor point at every viewport width?

And just to make sure, on mobile it expands to hit the nav launch button?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants