Skip to content
This repository has been archived by the owner on Jan 12, 2019. It is now read-only.

suppressScan config does not work on iOS #46

Closed
lolptdr opened this issue Sep 8, 2016 · 2 comments
Closed

suppressScan config does not work on iOS #46

lolptdr opened this issue Sep 8, 2016 · 2 comments

Comments

@lolptdr
Copy link
Contributor

lolptdr commented Sep 8, 2016

Required Information

  • Mode (Mock/Sandbox/Live): Live
  • Cordova Plugin Version: 2.0.2
  • Platforms (iOS/Android/Both): Both
  • Device OS Version and Device (iOS 9.x on an iPhone 6, Android Marshmallow on Nexus 6, etc.): iOS 9.3.5
  • PayPal-Debug-ID(s) (from any logs):

Issue Description

Please include as many details (logs, steps to reproduce, screenshots, frameworks/dependencies) as you can to help us reproduce this issue faster.

I've attempted to test the "suppressScan": true for iOS, but it doesn't seem to work. Checking https://github.com/card-io/card.io-Cordova-Plugin/blob/master/src/ios/CardIOCordovaPlugin.m file, I don't see the suppressScan variable there. I think it's simply adding this config boolean and verifying that the iOS source is referenced correctly.

I tested this on Android and it works fine.

@braebot
Copy link
Member

braebot commented Sep 11, 2016

You've found a legitimate difference between Android and iOS config. To only scan the image in iOS, you have to set detectionMode, to CardIODetectionModeCardImageOnly for the same behavior as Android. This is not mapped correctly in the Cordova plugin.

Can you please confirm that this is the behavior you desire? If so, we'd happy merge a PR, should you submit one.

@bluk
Copy link
Contributor

bluk commented Sep 25, 2016

This should be fixed with your commit in PR #45 . Will do a release shortly.

@bluk bluk closed this as completed Sep 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants