Skip to content
This repository has been archived by the owner on Jan 12, 2019. It is now read-only.

Missing Translation for Chinese Traditional (zh-Hant) #47

Closed
chrisj opened this issue May 15, 2014 · 6 comments
Closed

Missing Translation for Chinese Traditional (zh-Hant) #47

chrisj opened this issue May 15, 2014 · 6 comments

Comments

@chrisj
Copy link

chrisj commented May 15, 2014

Similar to this recent issue: #43

@chrisj chrisj changed the title Translation for Chinese Traditional (zh-Hant) Missing Translation for Chinese Traditional (zh-Hant) May 15, 2014
@dgoldman-pdx
Copy link
Member

@chrisj, please provide a much more detailed description of your issue.

@dgoldman-pdx
Copy link
Member

@chrisj please re-open this issue at any time with more details.

@chrisj
Copy link
Author

chrisj commented May 19, 2014

If I set languageOrLocale to zh-Hant_HK, it works correctly.

With the language set to Chinese Traditional and the region format set to Hong Kong SAR China

[[NSLocale preferredLanguages] objectAtIndex:0] returns zh-Hant
[[NSLocale currentLocale] localeIdentifier] returns en_HK

If I leave it to nil, it falls into the third case for some reason: "If card.io does not contain localized strings for a specified language, then it will fall back to American English."

I can get the correct result using:

[NSString stringWithFormat:@"%@_%@", NSLocaleCollatorIdentifier, NSLocaleCountryCode]

Should card.io handle this?

@dgoldman-pdx dgoldman-pdx reopened this May 19, 2014
@dgoldman-pdx
Copy link
Member

@chrisj yes, I believe that you're correct. card.io is not currently handling all permutations of Chinese language + region in a correct manner. We'll give this some more attention.

@dgoldman-pdx
Copy link
Member

@chrisj Hmm. We do need to tweak our code. But after we've done that, you'll still need to set your device's Region appropriately:

In iOS 7, if you set Region to Hong Kong SAR China, then as you observed the locale identifier will be en_HK.

But if you set Region to Chinese > Hong Kong SAR China, then the locale identifier will be zh_HK.

(We will change our code to recognize that zh "matches" zh-Hant in this situation.)

@dgoldman-pdx
Copy link
Member

Okay, @chrisj, give the latest release a try.

(Note: I've added some special-case code so that even zh-Hant + en_HK should work correctly.)

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants