-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotate generated classes #3104
Comments
I would consider adding something so SQLDelight module extensions can annotate the generated type, but as I always say to feature requests like this - modifying the dialect is always always always my last resort and I don't think is necessary here, so the extension would just make every type that module is applied to extend parcelable, or you hardcode the types in your extension. Anyways, unlikely to land a specific parcelable extension in SQLDelight but I think the ability to extend how a data class is annotated in an extension could make sense. |
Sounds good
Sounds good as well |
The biggest problem is the missing Kotlin representation. We currently use Supporting parcelable by adding the annotation and the interface should be easy to implement, except advanced parcelable support. But another use case, at least for me, is renaming the attributes of the query class. This does not only change the query class, but all usages too which is hard to implement with kotlin-poet only. Edit: turns out, we already have some kotlin representation, for example |
Probably a lot, this would be a major feature though and I really want to just stay focused on fixes until we get 2.0 out |
Absolutely 👍🏻 |
Will this become a feature in the future releases? |
Description
Now that we can do
id AS VALUE
andversion AS LOCK
and there's also the json extension would it be possible to support Parcelable using an extension?As for the syntax I'd imagine something like this:
This only works when adding the parcelable extension similar to how the json extension works. Ideally, the same syntax can be used for
CREATE VIEW
.It should also allow typealiasing to those types as when using Kotlin Multiplatform you usually do something like:
commonMain:
androidMain:
iosMain:
The text was updated successfully, but these errors were encountered: