Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for electron/fuses #152

Open
eXhumer opened this issue Apr 6, 2023 · 1 comment
Open

Support for electron/fuses #152

eXhumer opened this issue Apr 6, 2023 · 1 comment

Comments

@eXhumer
Copy link

eXhumer commented Apr 6, 2023

Is there any consideration for supporting electron/fuses? I would like to encrypt the cookies with [FuseV1Options.EnableCookieEncryption]: true fuse with my application, but making any fuse changes causes the python -m castlabs_evs.vmp sign-pkg command to fail with the following error. It makes binary level changes to executable to flip fuses, which causes the bad signature I think.

(evs-env) PS C:\Users\eXhumer\Projects\eXViewer> python -m castlabs_evs.vmp sign-pkg .\out\eXViewer-win32-x64\
Signing: .\out\eXViewer-win32-x64\eXViewer.exe
 - Verifying existing VMP signature
 - Signature invalid: Failed to verify signature
 - Requesting VMP signature
HTTPError: Signing request failed: 400 Bad Request
 <- ValidityError: Binary signature denied

The sign-pkg command has no issues if no fuses are changed from default.

By default, the following fuses are used

(evs-env) PS C:\Users\eXhumer\Projects\eXViewer> yarn run electron-fuses read --app .\out\eXViewer-win32-x64\eXViewer.exe      yarn run v1.22.19
$ C:\Users\eXhumer\Projects\eXViewer\node_modules\.bin\electron-fuses read --app .\out\eXViewer-win32-x64\eXViewer.exe
Analyzing app: eXViewer.exe
Fuse Version: v1
  RunAsNode is Enabled
  EnableCookieEncryption is Disabled
  EnableNodeOptionsEnvironmentVariable is Enabled
  EnableNodeCliInspectArguments is Enabled
  EnableEmbeddedAsarIntegrityValidation is Disabled
  OnlyLoadAppFromAsar is Disabled
  LoadBrowserProcessSpecificV8Snapshot is Disabled
Done in 0.49s.
@khwaaj
Copy link
Collaborator

khwaaj commented Apr 6, 2023

This is actually something that would be interesting to add support for. For now it is not planned, and it is likely to be rather complicated to add safely (so I can't give an estimate or anything), but I will make sure it is put up for consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants