Broken readOnly + required combination

[karlismelderis]

Describe the bug
if prop is set to readOnly and required POST/PUT body validation is failing with "required item is missing"
(I'm at version 4.1.0)

To Reproduce
example schemas:

Item:
      allOf:
        - $ref: '#/components/schemas/id'
        - $ref: '#/components/schemas/name'

    id:
      properties:
        id:
          type: string
          readOnly: true
      required:
        - id

    name:
      properties:
        name:
          type: string
      required:
        - name

Actual behavior
Error is thrown:

{
  "errorCode": "required.openapi.validation",
  "message": "should have required property 'id'",
  "path": ".body.id"
}

Expected behavior
if prop is set to readOnly it's not checked in POST/PUT body

[cdimascio]

@karlismelderis I created two tests using the schema provided above. both work correctly. It will be great if you can take at the two tests and modify them to reproduce the result you are seeing. Alternatively, if it's easier for you, please create simple canonical example demonstrating the issue, and post it to a github. i'll definitely have a look. thanks!

[karlismelderis]

ah missed comment. I will definitely try to create some code example for the case... or will find a bug in our schemas 🤔

[cdimascio]

Perhaps what u experienced is similar to #400. If so, I am working on a fix

[cdimascio]

@karlismelderis a number of improvements were made for readonly/required support via pr #414. they are available in v4.3.1 . please give it a try

[karlismelderis]

👍 that's exactly my case.
we are reusing schemas a lot so api spec is full with allOf e.t.c.
I managed to narrow down to exact same case:

      "ItemDetails": {
        "allOf": [
          {
            "type": "object",
            "properties": {
              "createdBy": {
                "type": "object",
                "readOnly": true,
                "allOf": [
                  {
                    "type": "object",
                    "properties": {
                      "userId": {
                        "type": "string",
                        "description": "Unique user identifier, normally username"
                      },
                      "firstName": {
                        "type": "string",
                        "description": "Given Name"
                      },
                      "lastName": {
                        "type": "string",
                        "description": "Last (Family) Name"
                      }
                    }
                  }
                ]
              }
            },
            "required": [
              "createdBy"
            ]
          },
          {
            "properties": {
              "name": {
                "type": "string"
              }
            },
            "required": [
              "name"
            ]
          }
        ]
      }

[cdimascio]

@karlismelderis thanks for the example.
does this occur in 4.3.x?
also, you might try adding type: object to the last object in the allOf list i.e.

{
  "type": "object",
  "properties": {
    "name": {
      "type": "string"
    }
  },
  "required": [
    "name"
  ]
}

[karlismelderis]

👍 true. we missed some type: object in yml.

and issue is gone with latest version.
thank you for fixing it.