From 7b0804b37e0929e1467079b371215c84049d6768 Mon Sep 17 00:00:00 2001
From: Stefan Baryakov <sbaryakov@talend.com>
Date: Fri, 23 Jan 2015 14:33:49 +0100
Subject: [PATCH] sort add_header values for vhost

---
 spec/defines/resource_vhost_spec.rb | 15 +++++++++++++++
 templates/vhost/vhost_header.erb    |  4 ++--
 2 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/spec/defines/resource_vhost_spec.rb b/spec/defines/resource_vhost_spec.rb
index f8c6616f9..c9eccff19 100644
--- a/spec/defines/resource_vhost_spec.rb
+++ b/spec/defines/resource_vhost_spec.rb
@@ -847,6 +847,21 @@
 
         it { is_expected.to contain_concat('/etc/nginx/sites-available/www_rspec-vhost_com.conf') }
       end
+
+      context 'when add_hedar is set' do
+        let :params do default_params.merge({
+          :add_header => { 'header3' => 'test value 3', 'header2' => 'test value 2', 'header1' => 'test value 1' }
+        }) end
+
+        it 'should have correctly ordered entries in the config' do
+          is_expected.to contain_concat__fragment("#{title}-header").with_content(/
+            %r|
+            \s+add_header\s+header1 test value 1;\n
+            \s+add_header\s+header2 test value 2;\n
+            \s+add_header\s+header3 test value 3;\n
+            |/)
+        end
+      end
     end
   end
 end
diff --git a/templates/vhost/vhost_header.erb b/templates/vhost/vhost_header.erb
index ce343a2b2..70c21156b 100644
--- a/templates/vhost/vhost_header.erb
+++ b/templates/vhost/vhost_header.erb
@@ -70,8 +70,8 @@ server {
   resolver                  <% Array(@resolver).each do |r| %> <%= r %><% end %>;
 <% end -%>
 <% if @add_header -%>
-  <%- @add_header.each do |key,value| -%>
-  add_header              <%= key %> <%= value %>;
+  <%- @add_header.keys.sort.each do |key| -%>
+  add_header              <%= key %> <%= @add_header[key] %>;
   <%- end -%>
 <% end -%>
 <% if @rewrite_to_https -%>