Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to ignore @tsd/typescript after upgrading tsd to 0.16 #60

Closed
aurelien-reeves opened this issue Jun 30, 2021 · 5 comments
Closed

Need to ignore @tsd/typescript after upgrading tsd to 0.16 #60

aurelien-reeves opened this issue Jun 30, 2021 · 5 comments

Comments

@aurelien-reeves
Copy link

aurelien-reeves commented Jun 30, 2021

Refs. cucumber/cucumber-js#1681

tsd 0.16 moved their types to a dedicated npm package @tsd/typescript (cf. tsdjs/tsd@5376484).

In cucumber-js, after upgrading tsd, dependency-lint reported the following:

$ dependency-lint
devDependencies:
  ✖ @tsd/typescript (missing)
      used in scripts:
        build-local

I had to add @tsd/typescript to the ignore list to prevent the error (cucumber/cucumber-js@f34c2a1)

@charlierudolph
Copy link
Owner

Oh interesting. This appears to be caused by @tsd/typescript being a drop in replacement for typescript and exporting executables of the same name. Given typescript is a direct dependency and tsd/typescript is not, I'm confused why this is reported. I'll dig into this a bit more

@charlierudolph
Copy link
Owner

Looks like tsc in the node_modules bin folder is correctly pointing to typescript so appears this is an issue with dependency-lint and how it determines what module executables are available. I can switch to reading the node_modules/.bin folder instead of looking at the package.json files of the other files.

@charlierudolph
Copy link
Owner

Fixed in 7.0.1

@charlierudolph
Copy link
Owner

This is fixed for linux based systems but seems need to figure something else out for windows based systems

@charlierudolph
Copy link
Owner

Fixed in 7.1.0 (reverted to old way of finding executables but limited to just direct dependencies / devDependencies)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants