-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Use consultation] How do you parse only part of the data? #116
Comments
In your case, when you call PALWORLD_CUSTOM_PROPERTIES: = {
".worldSaveData.GroupSaveDataMap": (group.decode, group.encode),
".worldSaveData.CharacterSaveParameterMap.Value.RawData": (
character.decode,
character.encode,
),
} This would skip processing of the other data that I have added. In the future, I might look into lazily evaluating the RawData structs such that you don't incur the parsing cost until you access it (if you consume the library, or if you dump it as JSON), or provide configuration options in the CLI to pick and choose. |
Thanks, that helps! |
Thanks for working on 4f8234f, that made this better! For context, I am building a C# app that runs On my server I am finding that the processing time is faster with the new If I understand correctly, My thought would be that passing in properties would exclude all other properties from the result. Ideally, I could pass Would you have any idea on how to accomplish that, aiming to reduce the overall execution time by reducing the payload needing to be saved? |
You can take a look at what https://github.com/magicbear/palworld-server-toolkit does to skip processing various properties. |
First of all, I would like to extend my heartfelt thanks for your project, which has solved many of my problems! I have developed a visualization tool for server management palworld-server-tool based on your project.
In the part that I wrote myself, particularly in structure.py, I only utilized
CharacterSaveParameterMap
andGroupSaveDataMap
. I did not use any of the other data.Before you updated the code on parsing WorkSaved data, my entire parsing process took less than 60 seconds, but now it generally exceeds 90 seconds.
I suspect that the increase in parsing data is the reason behind the longer processing time and higher memory usage (I am also aiming to keep memory usage as low as possible).
Hence, I am raising this issue to seek your advice on customizing the parsing of certain data, as I am somewhat at a loss.
The text was updated successfully, but these errors were encountered: