Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out newsarticle app into separate, project #67

Open
fgregg opened this issue Dec 25, 2017 · 3 comments
Open

Break out newsarticle app into separate, project #67

fgregg opened this issue Dec 25, 2017 · 3 comments

Comments

@fgregg
Copy link

fgregg commented Dec 25, 2017

I was starting to work on a project that involved developing a corpus of Chicago media articles, so I was delighted to find that y'all have done a great job writing the scrapers for that already.

Would you consider breaking newsarticle into a separate project? I'd be happy to help with that.

@meshulam
Copy link
Member

@fgregg cool! I'd love to talk through what that might look like. The newsarticle app is fairly standalone so the work would mostly be in separating out the CJP-specific stuff (Coding models and hardcoded values). Any other thoughts on what you'd need?

@fgregg
Copy link
Author

fgregg commented Dec 27, 2017

Let me take a pass at the start of a stand-alone repo, and that will be a good basis for discussion.

@fgregg
Copy link
Author

fgregg commented Dec 27, 2017

Hi @meshulam, so

  1. I started by pulling the newsarticle subdirectory into a new repo: https://github.com/datamade/chicago-newsarticles
  2. Then I removed all the code related to coding, and setup the package as an installable app: Remove Coding related models, views, and forms; make an installable app datamade/chicago-newsarticles#1

(this is easier to see if you look at the individual commits instead of the whole PR diff)

As you thought, the Coding related models, forms, and views are the biggest things to pull out of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants