{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":542295587,"defaultBranch":"master","name":"ngu-carousel","ownerLogin":"chivesrs","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2022-09-27T21:27:53.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/7110657?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1664314074.807599","currentOid":""},"activityList":{"items":[{"before":"6c83cf5c26ec8735890faa42e4b5b70c149558a8","after":"634001f1708b7e6775e7577660af61264e7ab511","ref":"refs/heads/master","pushedAt":"2023-06-09T00:35:41.227Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"chivesrs","name":null,"path":"/chivesrs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7110657?s=80&v=4"},"commit":{"message":"Revert \"fix: check length only on unwrapped data (#442)\"\n\nThis reverts commit 044a29499caff4bf2a9606711b21e8da9fefc570.","shortMessageHtmlLink":"Revert \"fix: check length only on unwrapped data (uiuniversal#442)\""}},{"before":"634001f1708b7e6775e7577660af61264e7ab511","after":"6c83cf5c26ec8735890faa42e4b5b70c149558a8","ref":"refs/heads/master","pushedAt":"2023-06-09T00:32:39.436Z","pushType":"push","commitsCount":1,"pusher":{"login":"chivesrs","name":null,"path":"/chivesrs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7110657?s=80&v=4"},"commit":{"message":"Attempt to restore https://github.com/uiuniversal/ngu-carousel/pull/458","shortMessageHtmlLink":"Attempt to restore uiuniversal#458"}},{"before":"7331f0e76f86748ee552fc060e7d1439c5a9966e","after":"634001f1708b7e6775e7577660af61264e7ab511","ref":"refs/heads/master","pushedAt":"2023-06-09T00:10:13.715Z","pushType":"push","commitsCount":2,"pusher":{"login":"chivesrs","name":null,"path":"/chivesrs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7110657?s=80&v=4"},"commit":{"message":"Revert \"fix: check length only on unwrapped data (#442)\"\n\nThis reverts commit 044a29499caff4bf2a9606711b21e8da9fefc570.","shortMessageHtmlLink":"Revert \"fix: check length only on unwrapped data (uiuniversal#442)\""}},{"before":"33862ed606538caa5c2c6db277f059076e96d2a6","after":"7331f0e76f86748ee552fc060e7d1439c5a9966e","ref":"refs/heads/master","pushedAt":"2023-06-08T22:33:26.199Z","pushType":"push","commitsCount":2,"pusher":{"login":"chivesrs","name":null,"path":"/chivesrs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7110657?s=80&v=4"},"commit":{"message":"docs: add luca-peruzzo as a contributor for code (#459)\n\nAdds @luca-peruzzo as a contributor for code.\r\n\r\nThis was requested by santoshyadavdev [in this\r\ncomment](https://github.com/uiuniversal/ngu-carousel/pull/458#issuecomment-1568135113)\r\n\r\n[skip ci]\r\n\r\n---------\r\n\r\nCo-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>","shortMessageHtmlLink":"docs: add luca-peruzzo as a contributor for code (uiuniversal#459)"}},{"before":"33862ed606538caa5c2c6db277f059076e96d2a6","after":"7331f0e76f86748ee552fc060e7d1439c5a9966e","ref":"refs/heads/master","pushedAt":"2023-06-08T22:33:26.152Z","pushType":"push","commitsCount":2,"pusher":{"login":"chivesrs","name":null,"path":"/chivesrs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7110657?s=80&v=4"},"commit":{"message":"docs: add luca-peruzzo as a contributor for code (#459)\n\nAdds @luca-peruzzo as a contributor for code.\r\n\r\nThis was requested by santoshyadavdev [in this\r\ncomment](https://github.com/uiuniversal/ngu-carousel/pull/458#issuecomment-1568135113)\r\n\r\n[skip ci]\r\n\r\n---------\r\n\r\nCo-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>","shortMessageHtmlLink":"docs: add luca-peruzzo as a contributor for code (uiuniversal#459)"}},{"before":"28caa0656336ab2b27c30efa05c8c34bee91d961","after":"33862ed606538caa5c2c6db277f059076e96d2a6","ref":"refs/heads/master","pushedAt":"2023-06-08T22:33:21.470Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"chivesrs","name":null,"path":"/chivesrs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7110657?s=80&v=4"},"commit":{"message":"build: add Angular 16 support & update packages (#450)\n\nHello,\r\n\r\nThis PR fixes https://github.com/uiuniversal/ngu-carousel/issues/449.\r\n\r\nWhat I did:\r\n\r\n- I couldn't use `yarn` to run the nx migration so I had to switch to\r\n`npm`:\r\n - deleted `yarn.lock`\r\n - deleted `node_modules`\r\n - `npm install`\r\n- I executed the nx migration (with `npm`) to `nx 16.1` which also\r\nmigrated to `Angular 16`\r\n - `npx nx migrate latest`\r\n - There was nothing related to `Angular 16` migration this time\r\n - I did not migrate to standalone nor inject pattern\r\n- I then had to update Storybook packages to `7.1.0-alpha.13` to support\r\n`Angular 16` + `Typescript 5` before installing the migrated packages\r\n- I removed `node_modules` & `package-lock.json` and switched back to\r\n`yarn`\r\n - then `yarn install`\r\n- I applied the migration\r\n - `yarn nx migrate --run-migrations`\r\n- The migration migrated Storybook to full version 7\r\n - For more information it created `storybook-migration-summary.md`\r\n- I had to switch back again to `npm` because `caniuse-lite` wasn't\r\ninstalling properly with `yarn` which caused problem when building\r\n - It was missing some files in `caniuse-lite/dist/unpacker`\r\n- I updated the `.gitignore` to reflect nx project migration\r\n - Properly ignore `reports` folders\r\n- I had to explicitly install `core-js`\r\n- I also had to update the import in `test.ts` of the lib to\r\n`core-js/stable/reflect`\r\n- I added `hammerjs` in `allowedCommonJsDependencies` for the demo app\r\n- I updated all packages to latest version\r\n- I scoped package versions to maximum `patch`\r\n- After updating all packages, `caniuse-lite` was installed properly so\r\nI switched back to `yarn` ๐Ÿ˜„\r\n- CI workflow `nodejs` now run on `Node.js 16` and `18`\r\n - `Node.js 14` is not compatible anymore with Angular\r\n- CI workflow `npm-publish` now run on `Node.js 18`\r\n- `actions/setup-node` updated to `v3` on all workflows\r\n\r\nProblems:\r\n\r\n- I was not able to fix `component-test`\r\n- I was not able to fix `storybook`\r\n\r\nNote:\r\n\r\n- Since the repo got moved to nx, it seems that some Typescript eslint\r\nrules were removed, if you want to add them back:\r\n- For `\"files\": [\"*.ts\"]` add `\"plugin:@nx/typescript\"` in the\r\n`\"extends\": [...]` array\r\n- I didn't add it cause I'm not sure how to properly fix all the\r\nproblems on the project\r\n- I removed the unused comments using previous eslint setup (before nx\r\nmigration) for cypress project (in `commands.ts`)\r\n\r\nTODO on your side:\r\n\r\n- Update compatibility array\r\n- Release a new major version `8.0.0`\r\n- Close branches related to package update","shortMessageHtmlLink":"build: add Angular 16 support & update packages (uiuniversal#450)"}},{"before":"33862ed606538caa5c2c6db277f059076e96d2a6","after":"28caa0656336ab2b27c30efa05c8c34bee91d961","ref":"refs/heads/master","pushedAt":"2023-05-17T22:40:17.408Z","pushType":"push","commitsCount":1,"pusher":{"login":"chivesrs","name":null,"path":"/chivesrs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7110657?s=80&v=4"},"commit":{"message":"Revert \"fix: check length only on unwrapped data (#442)\"\n\nThis reverts commit 044a29499caff4bf2a9606711b21e8da9fefc570.","shortMessageHtmlLink":"Revert \"fix: check length only on unwrapped data (uiuniversal#442)\""}},{"before":"e7ef1a839303143f17dc7294a69cfa58935ceb15","after":"33862ed606538caa5c2c6db277f059076e96d2a6","ref":"refs/heads/master","pushedAt":"2023-05-16T20:51:48.040Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"chivesrs","name":null,"path":"/chivesrs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7110657?s=80&v=4"},"commit":{"message":"build: add Angular 16 support & update packages (#450)\n\nHello,\r\n\r\nThis PR fixes https://github.com/uiuniversal/ngu-carousel/issues/449.\r\n\r\nWhat I did:\r\n\r\n- I couldn't use `yarn` to run the nx migration so I had to switch to\r\n`npm`:\r\n - deleted `yarn.lock`\r\n - deleted `node_modules`\r\n - `npm install`\r\n- I executed the nx migration (with `npm`) to `nx 16.1` which also\r\nmigrated to `Angular 16`\r\n - `npx nx migrate latest`\r\n - There was nothing related to `Angular 16` migration this time\r\n - I did not migrate to standalone nor inject pattern\r\n- I then had to update Storybook packages to `7.1.0-alpha.13` to support\r\n`Angular 16` + `Typescript 5` before installing the migrated packages\r\n- I removed `node_modules` & `package-lock.json` and switched back to\r\n`yarn`\r\n - then `yarn install`\r\n- I applied the migration\r\n - `yarn nx migrate --run-migrations`\r\n- The migration migrated Storybook to full version 7\r\n - For more information it created `storybook-migration-summary.md`\r\n- I had to switch back again to `npm` because `caniuse-lite` wasn't\r\ninstalling properly with `yarn` which caused problem when building\r\n - It was missing some files in `caniuse-lite/dist/unpacker`\r\n- I updated the `.gitignore` to reflect nx project migration\r\n - Properly ignore `reports` folders\r\n- I had to explicitly install `core-js`\r\n- I also had to update the import in `test.ts` of the lib to\r\n`core-js/stable/reflect`\r\n- I added `hammerjs` in `allowedCommonJsDependencies` for the demo app\r\n- I updated all packages to latest version\r\n- I scoped package versions to maximum `patch`\r\n- After updating all packages, `caniuse-lite` was installed properly so\r\nI switched back to `yarn` ๐Ÿ˜„\r\n- CI workflow `nodejs` now run on `Node.js 16` and `18`\r\n - `Node.js 14` is not compatible anymore with Angular\r\n- CI workflow `npm-publish` now run on `Node.js 18`\r\n- `actions/setup-node` updated to `v3` on all workflows\r\n\r\nProblems:\r\n\r\n- I was not able to fix `component-test`\r\n- I was not able to fix `storybook`\r\n\r\nNote:\r\n\r\n- Since the repo got moved to nx, it seems that some Typescript eslint\r\nrules were removed, if you want to add them back:\r\n- For `\"files\": [\"*.ts\"]` add `\"plugin:@nx/typescript\"` in the\r\n`\"extends\": [...]` array\r\n- I didn't add it cause I'm not sure how to properly fix all the\r\nproblems on the project\r\n- I removed the unused comments using previous eslint setup (before nx\r\nmigration) for cypress project (in `commands.ts`)\r\n\r\nTODO on your side:\r\n\r\n- Update compatibility array\r\n- Release a new major version `8.0.0`\r\n- Close branches related to package update","shortMessageHtmlLink":"build: add Angular 16 support & update packages (uiuniversal#450)"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyMy0wNi0wOVQwMDozNTo0MS4yMjcwOTRazwAAAAM90sAM","startCursor":"Y3Vyc29yOnYyOpK7MjAyMy0wNi0wOVQwMDozNTo0MS4yMjcwOTRazwAAAAM90sAM","endCursor":"Y3Vyc29yOnYyOpK7MjAyMy0wNS0xNlQyMDo1MTo0OC4wNDA0NTNazwAAAAMuHE6N"}},"title":"Activity ยท chivesrs/ngu-carousel"}