Remove Cells

[DarkMagus]

Introduction

I have problem deleting Elements from a graph. The following code is trying to delete 3 sibling elements linked to a parent element, but the elements remain in the graph after deletion. Am I messing something? Thanks lot.

paper.freeze();
graph.removeCells([graph.getCell('ft-1227795'), graph.getCell('ft-1227796'), graph.getCell('ft-1227797')]);
paper.unfreeze();
const cell = graph.getCell('ft-1227796');  // This cell should have been removed, so graph.getCell('ft-1227796') is expected to return null
console.log('cell', cell);   // However, the cell appears to still be present

The output of console.log shows that the graph field of the deleted cell is null. How come that graph still references the cell?

Steps to reproduce

No response

Restrictions & Constraints

No response

Does your question relate to JointJS or JointJS+. Select both if applicable.

JointJS+

[kumilingus]

What are the steps to reproduce this? It works as expected when I try.

[DarkMagus]

@kumilingus Thanks for your quick answer.
I did not try yet the second option with dry: true. However, I tried before option 1 by trying to clear the temporary graph after I copied its cells to the dendogram graph but I had the following issues:

1. tmpGraph.clear() crushed my program
2. tmpGraph.resetCells([]) produces strange results on the dendogram graph where some linkes (not all) disappeared from the dendogram

[kumilingus]

Please try the other one then.

tmpGraph.clear() crushed my program

What do you mean?

tmpGraph.resetCells([]) produces strange results on the dendogram graph where some linkes (not all) disappeared from the dendogram

This is a bug. cell.collection is undefined. cell.graph stays the same.

[DarkMagus]

@kumilingus
The dry: true flag solves the problem. Now, graph.removeCells works as expected. Thanks lot for your help

Regarding tmpGraph.clear() which crushed my program, I do not remember the exact error message but it has to do with LinkView.
If you like I can retry to produce the issue and send you the exact error message.

Thanks again for your help and patience!

[DarkMagus]

@kumilingus

As promised, here is the error message I got when calling tmpGraph.clear:

[kumilingus]

| tmpGraph.resetCells([]) produces strange results on the dendogram graph where some linkes (not all) disappeared from the dendogram

Fixed here: #2692

Error: LinkView: invalid target cell

It means there is no cell with target id in the graph. The graph.clear() seems to remove the references as expected.

[DarkMagus]

@kumilingus
After calling dendrogram.removeCells(cells), the dendogram's node containing the deleted fault tree does not show the right collapse button: it should show + button but it still showing - button despite the fact I have set its status to node.set('collapsed', true).

How can I force JointJS+ to redraw the node in order to show the right collapse sign?
The only way I found to force it to show the right collapse button is using this little trick:
graph.translate(0.0001, 0.0001);

is there a JointJS+ better way of achieving the trick?

Thanks

[DarkMagus]

@kumilingus
I tried the following:

1. Calling expandButton.update() directly - It works correctly
2. Requesting an update with elementView.requestUpdate(joint.dia.CellView.Flags.TOOLS); - It does not pass the compilation phase, I got the following error: Property 'Flags' does not exist on type 'typeof CellView'.
3. I did not try the third option as I do not need a highlighter to do what I want.

Although option 1 is working correctly, I would like to know why the second option is not working (just to advance my JointJS+ knowledge)

Thanks

[kumilingus]

My bad. It supposed to be like this:

elementView.requestUpdate(elementView.getFlag(joint.dia.ElementView.Flags.TOOLS));

[DarkMagus]

@kumilingus
I will try it and let you know - Thanks lot

[DarkMagus]

@kumilingus

Another question - I looked everywhere in JointJS+ documentation and could not find any entry for requestUpdate or getFlag

Am I looking into the wrong documentation page?

Thanks

[kumilingus]

This topic is not covered in the documentation yet. We need to port the article from the old docs and extend it.