Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pa11y and possible other dependency issues #289

Closed
shumatepf opened this issue Dec 20, 2022 · 5 comments · Fixed by #290
Closed

Pa11y and possible other dependency issues #289

shumatepf opened this issue Dec 20, 2022 · 5 comments · Fixed by #290

Comments

@shumatepf
Copy link
Contributor

The GitHub Action task for running pa11y is consistently failing. When upgrading pa11y to 3.0.1, the action passes but the tests still fail. I noticed this when the action triggered from dependabot bumping the pa11y version succeeded. Below is the task output for pa11y from that action:

Run npm run pa11y-ci:sitemap

> federalist-uswds-jekyll@1.3.0 pa11y-ci:sitemap /home/runner/work/uswds-site-sample/uswds-site-sample
> pa11y-ci --sitemap http://localhost:4000/sitemap.xml --sitemap-exclude "/*.pdf"  --sitemap-exclude "/admin"

Running Pa11y on 11 URLs:
 > http://localhost:4000/collections/ - Failed to run
 > http://localhost:4000/document-with-sidenav/ - Failed to run
 > http://localhost:4000/document/ - Failed to run
 > http://localhost:4000/201[9](https://github.com/shumatepf/uswds-site-sample/actions/runs/3735389750/jobs/6352134807#step:8:10)/01/[13](https://github.com/shumatepf/uswds-site-sample/actions/runs/3735389750/jobs/6352134807#step:8:14)/an-extra/ - Failed to run

This can be reproduced on any copy of the pages-uswds-jekyll template, including the one linked from the above action.

@drewbo
Copy link
Contributor

drewbo commented Dec 20, 2022

@shumatepf we've only tested the pa11y action up to version 2.4.0 and because it's pinned I think new sites should succeed on their initial builds unless the dependency is upgraded. If you're able to get 3.0.1 working, would you mind contributing back here?

@shumatepf
Copy link
Contributor Author

@drewbo The action ran initially when creating a clone of the template failed with the same issue.

@shumatepf
Copy link
Contributor Author

shumatepf commented Dec 20, 2022

pa11y/pa11y-ci#198 actually addresses this issue, it seems to be a bug with Ubuntu-22.04.

The action runs successfully with Ubuntu-20.04.

@drewbo
Copy link
Contributor

drewbo commented Dec 20, 2022

Ah, apologies I only checked the latest builds. Good research and we can downgrade the prescribed runner in the template until this is resolved. Thanks!

@drewbo
Copy link
Contributor

drewbo commented Dec 21, 2022

Closed via #291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants