Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect subjet p4 used in PUPPI SD mass correction lookup #234

Open
lcorcodilos opened this issue Feb 19, 2020 · 0 comments
Open

Incorrect subjet p4 used in PUPPI SD mass correction lookup #234

lcorcodilos opened this issue Feb 19, 2020 · 0 comments

Comments

@lcorcodilos
Copy link
Contributor

From this HN thread [1], it seems that the PUPPI SD mass correction done in fatJetUncertainties.py is not correct because it uses the subjets with the JECs already applied [2]. While there was a suggestion to do the proper order of corrections externally, I believe it should be changed here as well since there are users who didn't know about this bug (I didn't know about it and I'm sure others are in the same boat).

[1] - https://hypernews.cern.ch/HyperNews/CMS/get/jet-algorithms/562/1/1.html
[2] -

groomedP4 = subJets[ jet.subJetIdx1 ].p4() + subJets[ jet.subJetIdx2].p4() #check subjet jecs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant