TauWPThreshold.h uses exception throws as flow control

[wddgit]

When debugging a problem in the addOn PR tests, I was trying use catch throw. I hit a throw from this line of code 17 times in a row and gave up trying to simply continue past it. I had to set an explicit breakpoint after this constructor to get past this troublesome line of code.

https://cmssdt.cern.ch/dxr/CMSSW/source/RecoTauTag/RecoTau/interface/TauWPThreshold.h?from=TauWPThreshold&case=true#17

I didn't spend a lot of time studying this, but at first glance it does not look like a truly exceptional circumstance (possibly I am incorrect and there is some kind of bug here).

It would make debugging exceptions with catch throw much easier if we didn't have this behavior going on. I would suggestion replacing this with some other control structure that does not use try-catch.

[cmsbuild]

A new Issue was created by @wddgit W. David Dagenhart.

@makortel, @rappoccio, @sextonkennedy, @smuzaffar, @antoniovilela, @Dr15Jones can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[makortel]

assign RecoTauTag/RecoTau

[cmsbuild]

New categories assigned: reconstruction

@jfernan2,@mandrenguyen you have been requested to review this Pull request/Issue and eventually sign? Thanks

[makortel]

@cms-sw/tau-pog-l2

[makortel]

E.g. std::from_chars() provides a way to do string-to-number conversion without exceptions, while also recognizing parsing failures.

[mandrenguyen]

+reconstruction
Addressed by #43890
Thanks @mbluj !

[cmsbuild]

This issue is fully signed and ready to be closed.