Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in note are incorrect #157

Closed
CsatariGergely opened this issue Aug 25, 2023 · 5 comments
Closed

Links in note are incorrect #157

CsatariGergely opened this issue Aug 25, 2023 · 5 comments

Comments

@CsatariGergely
Copy link

The note in the README file refers to github.com/container-orchestrated-devices/container-device-interface/pkg/cdi while the correct reference is https://github.com/cncf-tags/container-device-interface/tree/main/pkg/cdi.

@elezar
Copy link
Contributor

elezar commented Sep 7, 2023

@CsatariGergely thanks for calling this out. We recently migrated our repos and the docs still refer to the old address. Would you be up to creating a PR that addresses the inconsistencies?

@ATREAY
Copy link
Contributor

ATREAY commented Sep 27, 2023

hey @elezar, can I work on this issue?

@elezar
Copy link
Contributor

elezar commented Sep 27, 2023

@ATREAY you're welcome to submit a PR.

We were going to wait on a "vanity URL" for this cncf-tags repos, but this does not have to be a blocker. (see cncf/toc#1152).

@ATREAY
Copy link
Contributor

ATREAY commented Sep 28, 2023

Hey @elezar, I've made the necessary changes. Please take a look when you get a chance.

@elezar
Copy link
Contributor

elezar commented Jan 10, 2024

As far as I understand this has been addressed. Closing this issue. Please reopen if the links are still invalid.

@elezar elezar closed this as completed Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants