Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clipping on shelf #1070

Open
peterkos opened this issue Dec 20, 2020 · 1 comment · Fixed by #1089
Open

Clipping on shelf #1070

peterkos opened this issue Dec 20, 2020 · 1 comment · Fixed by #1089
Labels
BH7 bug

Comments

@peterkos
Copy link
Contributor

Due to fixed height

Screen Shot 2020-12-19 at 7 13 55 PM
@peterkos peterkos added the BH7 label Dec 20, 2020
@peterkos peterkos mentioned this issue Dec 20, 2020
Merged
@JeremyRudman JeremyRudman self-assigned this Dec 23, 2020
@JeremyRudman JeremyRudman linked a pull request Jan 5, 2021 that will close this issue
fixed: shelf clipping bug on large screen sizes #1089
Merged
@peterkos peterkos added the bug label Jan 5, 2021
@ww2497
Copy link
Member

ww2497 commented Jan 7, 2021

Still seems to happen when the height of the screen is less than half of the width for resolutions over 1500px wide.

Possible solution: min height based on the vw

@ww2497 ww2497 reopened this Jan 7, 2021
@peterkos peterkos reopened this Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BH7 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed: shelf clipping bug on large screen sizes codeRIT/brickhack.io
3 participants
@peterkos @ww2497 @JeremyRudman