New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StratumClient.close doesn't close transport #16

Open

doc-hex opened this issue Feb 25, 2019 · 1 comment

Labels

bug

Contributor

doc-hex commented Feb 25, 2019

although it closes the protocol, the transport needs to be closed as well
I've observed TCP socket to server remains in place.

doc-hex added the bug label

Contributor Author

doc-hex commented Feb 25, 2019

but connectrum/protocol.py StratumProtocol.close() does call transport.close()!

philippem mentioned this issue

propagate lost server connection errors to client #24

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment