Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The generated pkgs/envs.txt does not honour info['channel_remap'] #654

Closed
jaimergp opened this issue Feb 27, 2023 · 3 comments · Fixed by #656
Closed

The generated pkgs/envs.txt does not honour info['channel_remap'] #654

jaimergp opened this issue Feb 27, 2023 · 3 comments · Fixed by #656
Labels
locked [bot] locked due to inactivity type::bug describes erroneous operation, use severity::* to classify the type

Comments

@jaimergp
Copy link
Contributor

The generated pkgs/envs.txt does not honour info['channel_remap'], so the generated installer fails for locally built channels, by reclaiming the path of the package from the environment running constructor.

The problem seems in preconda.py.

Files pkgs/urls.txt and pkgs/urls are written using get_final_url(info, url) (within all_final_urls_md5s --> this honours channel_remap; but pkgs/envs_txt uses info["_urls"] directly.

You have the remap info already in final_urls_md5s, so the solution -hopefully- is as simple as:

Replace

    # base environment file used with conda install --file
    # (list of specs/dists to install)
    write_env_txt(info, dst_dir, info["_urls"])

with

    # base environment file used with conda install --file
    # (list of specs/dists to install)
    write_env_txt(info, dst_dir, final_urls_md5s)

Equal change is required for sub environment:

replace

        write_env_txt(info, env_dst_dir, env_info["_urls"])

with

        write_env_txt(info, env_dst_dir, env_urls_md5)

==> generated installer than works in my cases

Originally posted by @EisW in #559 (comment)

@jaimergp jaimergp added the type::bug describes erroneous operation, use severity::* to classify the type label Feb 27, 2023
@jaimergp
Copy link
Contributor Author

Thanks for the report @EisW. We'll track the progress here. If you have time to open a PR with a couple tests, that'd be awesome, but no pressure :D

@EisW
Copy link
Contributor

EisW commented Mar 8, 2023

In my honest opinion the PR should be finished now.
Did I miss something?

@EisW
Copy link
Contributor

EisW commented Mar 21, 2023

Can you trigger CI, to see if it works now? Or can I trigger it myself?

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Mar 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity type::bug describes erroneous operation, use severity::* to classify the type
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants