Output NSIS error messages

[marcoesters]

Checklist

• I added a descriptive title
• I searched open requests and couldn't find a duplicate

What is the idea?

Catch and forward the error message output by makensis.exe to facilitate debugging.

Why is this needed?

When makensis.exe fails, the error message is along the lines of

subprocess.CalledProcessError: Command '['C:\\Users\\runneradmin\\miniconda3\\NSIS\\makensis.exe', '/V2', 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpe83oee6u\\main.nsi']' returned non-zero exit status 1.

This does not help developers understand why their build failed. Running makensis.exe directly, however, will yield an error message.

However, running makensis.exe directly is not always convenient to do (on a CI, for example), and should not be necessary to do in the first place. Outputting the error message via constructor will facilitate debugging.

What should happen?

constructor should forward the error message provided by makensis.exe.

Additional Context

No response

[jaimergp]

It's there in debug mode:

constructor/constructor/winexe.py

Lines 466 to 472 in b6c4233

	verbosity = f"{'/' if sys.platform == 'win32' else '-'}V{4 if verbose else 2}"
	args = [MAKENSIS_EXE, verbosity, nsi]
	logger.info('Calling: %s', args)
	process = run(args, capture_output=True, text=True)
	logger.debug("makensis stdout:\n'%s'", process.stdout)
	logger.debug("makensis stderr:\n'%s'", process.stderr)
	process.check_returncode()

But yea, we could change the debug level if the returncode != 0.