Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tgrade-valset: Wrong automatic jailing logic #184

Closed
maurolacy opened this issue Sep 19, 2022 · 1 comment
Closed

tgrade-valset: Wrong automatic jailing logic #184

maurolacy opened this issue Sep 19, 2022 · 1 comment
Assignees

Comments

@maurolacy
Copy link
Contributor

maurolacy commented Sep 19, 2022

If verify_validators is enabled, non-signing validators must be jailed only if they are not already jailed. If not, it'll be effectively impossible for them to get out of jail, because their jailing expiration date will be continuously moved forward.

// validator is inactive for at least MISSED_BLOCKS, jail!
JAIL.save(deps.storage, operator_addr, &expiration)

Write a test to confirm / reproduce this bug, and the fix.

@maurolacy maurolacy added the bug Something isn't working label Sep 19, 2022
@maurolacy maurolacy self-assigned this Sep 19, 2022
@maurolacy maurolacy changed the title tgrade-valset: Wrong jailing logic tgrade-valset: Wrong automatic jailing logic Sep 19, 2022
@maurolacy
Copy link
Contributor Author

Closing as not needed / already solved (see #187).

@maurolacy maurolacy removed the bug Something isn't working label Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant