Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valset: mark "active" validators in ValidatorInfo #23

Closed
alpe opened this issue Jan 18, 2022 · 2 comments · Fixed by #37
Closed

valset: mark "active" validators in ValidatorInfo #23

alpe opened this issue Jan 18, 2022 · 2 comments · Fixed by #37
Assignees

Comments

@alpe
Copy link

alpe commented Jan 18, 2022

When the ValidatorInfo returns a bool value when in the active set then I can set the right status value for GRPC queries without doing a second query on the active set.

Relates to confio/tgrade#124

@alpe alpe changed the title valset: show "active" validators in ValidatorInfo valset: mark "active" validators in ValidatorInfo Jan 18, 2022
@uint uint self-assigned this Jan 25, 2022
@uint
Copy link
Contributor

uint commented Jan 25, 2022

@alpe As far as I understand this, ValidatorInfo is only provided in ListActiveValidatorsResponse, which returns only active validators anyway.

Did you mean adding the bool to OperatorResponse in ListValidatorResponse?

#[derive(Serialize, Deserialize, Clone, PartialEq, JsonSchema, Debug)]
pub struct ListValidatorResponse {
    pub validators: Vec<OperatorResponse>,
}

#[derive(Serialize, Deserialize, Clone, PartialEq, JsonSchema, Debug)]
pub struct ListActiveValidatorsResponse {
    pub validators: Vec<ValidatorInfo>,
}

@alpe
Copy link
Author

alpe commented Jan 26, 2022

yes, please add to OperatorResponse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants