Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eddsa gadget circuit is not correctly solved #1

Closed
ThomasPiellard opened this issue Feb 25, 2020 · 0 comments
Closed

Eddsa gadget circuit is not correctly solved #1

ThomasPiellard opened this issue Feb 25, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@ThomasPiellard
Copy link
Collaborator

In r1cs.go, In the solveR1c method, when solving for a binary decomposition the solver checks if one of the bit is not already instantiated (it can be the case if we enforce a certain bit to be 1 for instance). In eddsa gadget, when solving the circuit, for the scalar multiplications, all the bits are falsely instantiated, so solveR1c does not solve them, and they all end up being 0.

Note: when removing the check if a wire is instantiate in solveR1c, the solver works.

@ThomasPiellard ThomasPiellard added the bug Something isn't working label Feb 25, 2020
ThomasPiellard added a commit that referenced this issue Feb 25, 2020
gbotrel added a commit that referenced this issue Feb 25, 2020
@gbotrel gbotrel closed this as completed Feb 25, 2020
@Sickies Sickies mentioned this issue Jun 27, 2024
12 tasks
ThomasPiellard added a commit to ThomasPiellard/gnark that referenced this issue Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants