Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select : prompt is no longer displayed #281

Closed
tbergerd opened this issue Sep 21, 2023 · 1 comment
Closed

Select : prompt is no longer displayed #281

tbergerd opened this issue Sep 21, 2023 · 1 comment
Milestone

Comments

@tbergerd
Copy link
Contributor

This is a regression at head I noticed.
cargo run --example select

Behavior :
The four options get displayed without the prompt
Expected :
the "Pick your flavor" prompt is correctly displayed (works fine in dialoguer 0.10.4)

Specifically the reg was introduced by fix #267
I'm under the impression Paging::update is only meant to be called after Paging::render_prompt
calling it before makes it so self.activity_transition is set to false (iff there is only one page. notice we do see the prompt correctly on the third part of the 'select' example because it has 2 pages)
here I think we only want to update self.current_page (to fix the issue mentioned in #267)

I'll try and submit a fix but I'm opening the issue in case what I propose is not what we want

@pksunkara pksunkara added this to the 0.11.0 milestone Sep 21, 2023
@pksunkara
Copy link
Collaborator

I think that sounds about right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants