diff --git a/internal/image/oci_test.go b/internal/image/oci_test.go index 55e6073c49..fe4021b758 100644 --- a/internal/image/oci_test.go +++ b/internal/image/oci_test.go @@ -497,6 +497,8 @@ func TestManifestOCI1ConvertToManifestSchema1(t *testing.T) { var expected manifest.NonImageArtifactError assert.ErrorAs(t, err, &expected) + // FIXME: Test that conversion of an encrypted image fails + // Conversion to schema1 with encryption fails _, err = original.UpdatedImage(context.Background(), types.ManifestUpdateOptions{ LayerInfos: layerInfosWithCryptoOperation(original.LayerInfos(), types.Encrypt), @@ -507,6 +509,8 @@ func TestManifestOCI1ConvertToManifestSchema1(t *testing.T) { }) assert.Error(t, err) + // FIXME: Test that conversion with decryption is possible (make it work first) + // FIXME? Test also the other failure cases, if only to see that we don't crash? } @@ -535,6 +539,8 @@ func TestConvertToManifestSchema2(t *testing.T) { var expected manifest.NonImageArtifactError assert.ErrorAs(t, err, &expected) + // FIXME: Test that conversion of an encrypted image fails + // Conversion to schema2 with encryption fails _, err = original.UpdatedImage(context.Background(), types.ManifestUpdateOptions{ LayerInfos: layerInfosWithCryptoOperation(original.LayerInfos(), types.Encrypt), @@ -542,6 +548,8 @@ func TestConvertToManifestSchema2(t *testing.T) { }) assert.Error(t, err) + // FIXME: Test that conversion with decryption is possible (make it work first) + // FIXME? Test also the other failure cases, if only to see that we don't crash? }