From 5cef7d15e45fd739c33f88e2413310d560aec5b0 Mon Sep 17 00:00:00 2001
From: nick-funk <code@nickfunk.com>
Date: Thu, 30 May 2024 13:06:43 -0600
Subject: [PATCH] update all remaining build actions for GHA

also remove debug testing action from `build-and-test.yml`
---
 .github/workflows/build-and-test.yml    | 15 ++-------------
 .github/workflows/build-test-deploy.yml |  6 +++---
 2 files changed, 5 insertions(+), 16 deletions(-)

diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml
index 931899ff0b..de5cf65a7b 100644
--- a/.github/workflows/build-and-test.yml
+++ b/.github/workflows/build-and-test.yml
@@ -83,20 +83,9 @@ jobs:
         run: sh scripts/build.sh
       - name: Verify Bundle Size
         run: cd client && ./node_modules/.bin/bundlesize --enable-github-checks
-      # Debugging
-      - name: Build, Tag, Push (Debug)
-        uses: docker/build-push-action@v5
-        if: github.ref == 'refs/heads/fix/build-tag-push'
-        with:
-          push: true
-          tags: ${{ env.IMAGE_REPOSITORY }}:debug-test
-          build-args: |
-            REVISION_HASH=${GITHUB_SHA}
-          cache-from: type=registry,ref=${{ env.IMAGE_CACHE_REPOSITORY }}:cache-debug
-          cache-to: type=registry,ref=${{ env.IMAGE_CACHE_REPOSITORY }}:cache-debug
       # Build tag push the image after a merge to develop
       - name: Build, Tag, Push
-        uses: docker/build-push-action@v4
+        uses: docker/build-push-action@v5
         if: github.ref == 'refs/heads/develop'
         with:
           push: true
@@ -107,7 +96,7 @@ jobs:
           cache-to: type=registry,ref=${{ env.IMAGE_CACHE_REPOSITORY }}:cache-develop
       # Build tag push the release candidate image when the branch name begins with release-
       - name: Build, Tag, Push RC
-        uses: docker/build-push-action@v4
+        uses: docker/build-push-action@v5
         if: startsWith( github.ref, 'refs/heads/release-')
         with:
           push: true
diff --git a/.github/workflows/build-test-deploy.yml b/.github/workflows/build-test-deploy.yml
index 2cc6083c13..409d47b1bb 100644
--- a/.github/workflows/build-test-deploy.yml
+++ b/.github/workflows/build-test-deploy.yml
@@ -22,7 +22,7 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v3
       - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v2
+        uses: docker/setup-buildx-action@v3
       - uses: webfactory/ssh-agent@v0.7.0
         with:
           ssh-private-key: ${{ secrets.REPO_PATCHED_DEPLOY_KEY }}
@@ -98,7 +98,7 @@ jobs:
           echo "MINOR_TAG=${MAJOR}.${MINOR}" >> $GITHUB_ENV
           echo "PATCH_TAG=${MAJOR}.${MINOR}.${PATCH}" >> $GITHUB_ENV
       - name: Build, Tag, Push Major Tag
-        uses: docker/build-push-action@v4
+        uses: docker/build-push-action@v5
         with:
           push: true
           tags: ${{ env.IMAGE_REPOSITORY }}:${{ env.MAJOR_TAG }}
@@ -107,7 +107,7 @@ jobs:
           cache-from: type=registry,ref=${{ env.IMAGE_CACHE_REPOSITORY }}:cache-major
           cache-to: type=registry,ref=${{ env.IMAGE_CACHE_REPOSITORY }}:cache-major
       - name: Build, Tag, Push Minor Tag
-        uses: docker/build-push-action@v4
+        uses: docker/build-push-action@v5
         with:
           push: true
           tags: ${{ env.IMAGE_REPOSITORY }}:${{ env.MINOR_TAG }}