Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: starship-cli, wait-for-pods exists quickly after Running state #483

Closed
Anmol1696 opened this issue Jun 14, 2024 · 1 comment · Fixed by #486
Closed

bug: starship-cli, wait-for-pods exists quickly after Running state #483

Anmol1696 opened this issue Jun 14, 2024 · 1 comment · Fixed by #486

Comments

@Anmol1696
Copy link
Collaborator

Overview

Currently, the starship wait-for-pods (so also start) command exists quickly after getting all pods in Running state, which could be a bug.

Example: https://github.com/cosmology-tech/starship/actions/runs/9504181248/job/26225850829

Proposal

We need to:

  • give it more time to recover: pods seem to self heal as well after 1 or 2 crashlookbackoff
  • check for running state for longer, 5-10secs to make sure everything is up and running
  • proper exit if things did not run as usual

Note: Even if the Status: Running is achived by the pods, the Ready state need to be checked to make sure the installation is done properly.

@Anmol1696
Copy link
Collaborator Author

Here as well, we can see: https://github.com/cosmology-tech/starship/actions/runs/9514253431/job/26226066554?pr=476

The pods are in Running state but not ready. Need to check for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant