Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle additional x/auth module app config parameters #12055

Closed
Tracked by #11899
aaronc opened this issue May 26, 2022 · 2 comments · Fixed by #13684
Closed
Tracked by #11899

Handle additional x/auth module app config parameters #12055

aaronc opened this issue May 26, 2022 · 2 comments · Fixed by #13684
Assignees

Comments

@aaronc
Copy link
Member

aaronc commented May 26, 2022

In #12019, we didn't add configuration parameters for:

  • func() types.AccountI which is a parameter for NewAccountKeeper, and
  • types.RandomGenesisAccountsFn which is a parameter to auth.NewModule

I propose we handle these with google.protobuf.Any in the auth Module config object.

The question is, how do we actually map the Any to the function? Since these now live in the API module do we take an approach similar to that outlined here: https://github.com/cosmos/cosmos-sdk/blob/963bbae8b190df8743196005a43158277a9954c8/core/extension/extension.go

@julienrbrt
Copy link
Member

julienrbrt commented Oct 28, 2022

In #13684 I simply add the function in depinject.Supply. This is not ideal (we do the same for mint), but that still let a chain dev to modify the value. We can always increment on it later with Any I think.

@aaronc
Copy link
Member Author

aaronc commented Oct 28, 2022

I'm not seeing an example in that PR yet, but I think using depinject.Supply is an okay compromise for now 👍

@julienrbrt julienrbrt self-assigned this Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants