Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(sdk.Context): Slow KVStore operation #14202

Closed
testinginprod opened this issue Dec 7, 2022 · 3 comments
Closed

perf(sdk.Context): Slow KVStore operation #14202

testinginprod opened this issue Dec 7, 2022 · 3 comments
Assignees
@testinginprod
Labels
T: Performance Performance improvements

Comments

@testinginprod
Copy link
Contributor

The operation to get a KVStore given a store key is too slow for what it does, which should be a simple map lookup and a gaskv wrapping:

goos: darwin
goarch: arm64
pkg: github.com/cosmos/cosmos-sdk/types
BenchmarkContext_KVStore
BenchmarkContext_KVStore-10    	 8278102	       158.2 ns/op
PASS
@testinginprod testinginprod added the T: Performance Performance improvements label Dec 7, 2022
@testinginprod testinginprod mentioned this issue Dec 7, 2022
Closed
19 tasks
@ValarDragon
Copy link
Contributor

Agreed, have ran into this being an oddly high slowdown in our tests as well

@tac0turtle
Copy link
Member

Was this closed @testinginprod

@testinginprod
Copy link
Contributor Author

yes @tac0turtle was closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@testinginprod testinginprod

Labels
T: Performance Performance improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ValarDragon @tac0turtle @testinginprod