Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parity between AutoCLI and CLI #16651

Closed
julienrbrt opened this issue Jun 22, 2023 · 2 comments
Closed

Parity between AutoCLI and CLI #16651

julienrbrt opened this issue Jun 22, 2023 · 2 comments
Assignees
Labels

Comments

@julienrbrt
Copy link
Member

julienrbrt commented Jun 22, 2023

Noticed two differences between autocli outputs and previous CLI outputs:

  1. JSON and YAML output are nested, while previously not:

current:

$ simd q auth params
max_memo_characters: "256"
sig_verify_cost_ed25519: "590"
sig_verify_cost_secp256k1: "1000"
tx_sig_limit: "7"
tx_size_cost_per_byte: "10"
$ simd q auth params --output json
{"max_memo_characters":"256","tx_sig_limit":"7","tx_size_cost_per_byte":"10","sig_verify_cost_ed25519":"590","sig_verify_cost_secp256k1":"1000"}

autocli:

$ simd q auth params
params:
  max_memo_characters: "256"
  sig_verify_cost_ed25519: "590"
  sig_verify_cost_secp256k1: "1000"
  tx_sig_limit: "7"
  tx_size_cost_per_byte: "10"
$ simd q auth params --output json
{
  "params": {
    "max_memo_characters": "256",
    "tx_sig_limit": "7",
    "tx_size_cost_per_byte": "10",
    "sig_verify_cost_ed25519": "590",
    "sig_verify_cost_secp256k1": "1000"
  }
}
  1. Coin display is different (ref: feat(x/distribution): add autocli config query #16218 (review))
    image

Proposal

I believe the behavior 1. is better in AutoCLI and should stay coherent with gRPC. We should add an UPGRADING.md disclaimer for that.
Behavior 2. is incorrect and should be fixed.

@julienrbrt julienrbrt self-assigned this Jun 22, 2023
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Jun 22, 2023
@julienrbrt julienrbrt removed the needs-triage Issue that needs to be triaged label Jun 22, 2023
@julienrbrt
Copy link
Member Author

For point 2, ref: #10863

@julienrbrt
Copy link
Member Author

Closing this as point 2 is tracked by #10863 and point 1 has been solved by a doc update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants